Uploaded image for project: 'ARCHIVED: ui-search-es'
  1. ARCHIVED: ui-search-es
  2. UISEES-66

prefer @folio/stripes exports to private paths when importing components

    XMLWordPrintable

Details

    • Bug
    • Status: Closed (View Workflow)
    • TBD
    • Resolution: Won't Do
    • None
    • None
    • None
    • Falcon

    Description

      Overview: component imports should happen through the @folio/stripes/${repo} namespace rather than directly via the repo's private path. e.g. prefer

      import LocationSelection from '@folio/stripes/smart-components/LocationSelection';
      

      instead of

      import LocationSelection from '@folio/stripes-smart-components/lib/LocationSelection';
      

      The following files contain incorrect imports:

      ./ui-inventory-es/src/settings/HRIDHandling/HRIDHandlingSettings.js:9:import { stripesConnect } from '@folio/stripes-core';
      ./ui-inventory-es/src/edit/holdings/HoldingsForm.js:23:import { AppIcon, IntlConsumer } from '@folio/stripes-core';
      ./ui-inventory-es/src/edit/items/ItemForm.js:30:} from '@folio/stripes-core';
      ./ui-inventory-es/src/components/SearchAndSort/makeQueryFunction.js:1:import { compilePathTemplate } from '@folio/stripes-connect/RESTResource/RESTResource';
      ./ui-inventory-es/src/components/SearchAndSort/makeQueryFunction.js:2:import { filters2cql } from '@folio/stripes-components/lib/FilterGroups';
      ./ui-inventory-es/src/components/SearchAndSort/makeQueryFunction.js:3:import escapeCqlValue from '@folio/stripes-util/lib/escapeCqlValue';
      ./ui-inventory-es/src/components/SearchAndSort/components/SearchButton/SearchButton.js:10:} from '@folio/stripes-components';
      ./ui-inventory-es/src/components/SearchAndSort/components/CollapseFilterPaneButton/CollapseFilterPaneButton.js:8:import { PaneHeaderIconButton, Tooltip } from '@folio/stripes-components';
      ./ui-inventory-es/src/components/SearchAndSort/components/CheckboxFilter/CheckboxFilter.js:4:import { Checkbox } from '@folio/stripes-components';
      ./ui-inventory-es/src/components/SearchAndSort/components/DateRangeFilter/DateRangeFilter.js:5:import { TextField, Button } from '@folio/stripes-components';
      ./ui-inventory-es/src/components/SearchAndSort/components/NoResultsMessage/NoResultsMessage.js:10:import { Button, Icon } from '@folio/stripes-components';
      ./ui-inventory-es/src/components/SearchAndSort/components/ResetButton/ResetButton.js:10:import { Button, Icon } from '@folio/stripes-components';
      ./ui-inventory-es/src/components/SearchAndSort/components/ExpandFilterPaneButton/ExpandFilterPaneButton.js:8:import { PaneHeaderIconButton, Tooltip } from '@folio/stripes-components';
      ./ui-inventory-es/src/components/SearchAndSort/components/MultiSelectionFilter/MultiSelectionFilter.js:4:import { MultiSelection } from '@folio/stripes-components';
      ./ui-inventory-es/src/components/SearchAndSort/SearchAndSort.js:29:} from '@folio/stripes-components/lib/FilterGroups';
      ./ui-inventory-es/src/components/SearchAndSort/SearchAndSort.js:38:} from '@folio/stripes-components';
      ./ui-inventory-es/src/components/SearchAndSort/SearchAndSort.js:39:import { withModule } from '@folio/stripes-core/src/components/Modules';
      ./ui-inventory-es/src/components/SearchAndSort/SearchAndSort.js:45:} from '@folio/stripes-core';
      ./ui-inventory-es/src/components/SearchAndSort/SearchAndSort.js:46:import Tags from '@folio/stripes-smart-components/lib/Tags';
      ./ui-inventory-es/src/components/CheckboxFacet/CheckboxFacetList.js:11:} from '@folio/stripes-components';
      ./ui-inventory-es/src/components/HoldingsRecordFilters/HoldingsRecordFilters.js:10:import { AccordionSet } from '@folio/stripes-components';
      ./ui-inventory-es/src/components/ElasticQueryField/ElasticQueryField.js:6:import TextArea from '@folio/stripes-components/lib/TextArea';
      ./ui-inventory-es/src/components/ElasticQueryField/ElasticQueryField.js:7:import { Highlighter } from '@folio/stripes-components';
      ./ui-inventory-es/src/components/SearchField/SearchField.js:12:import Select from '@folio/stripes-components/lib/Select';
      ./ui-inventory-es/src/components/SearchField/SearchField.js:13:import TextField from '@folio/stripes-components/lib/TextField';
      ./ui-inventory-es/src/components/SearchField/SearchField.js:14:import TextFieldIcon from '@folio/stripes-components/lib/TextField/TextFieldIcon';
      ./ui-inventory-es/src/components/SearchField/stories/BasicUsage.js:6:import Checkbox from '@folio/stripes-components/lib/Checkbox';
      

      TestRail: Results

        Attachments

          Issue Links

            Activity

              People

                Unassigned Unassigned
                zburke Zak_Burke
                Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved:

                  TestRail: Runs

                    TestRail: Cases