Uploaded image for project: 'stripes-smart-components'
  1. stripes-smart-components
  2. STSMACOM-415

Notes | Replace noteData.type and noteData.title - with No value component

    XMLWordPrintable

    Details

    • Template:
    • Sprint:
      eHoldings Sprint 111
    • Story Points:
      1
    • Development Team:
      Spitfire
    • Release:
      R1 2021 Bug Fix

      Description

      Work

      Replace {
      {value={get(item, 'status.name', '-')}}

      With <NoValue> component

      In these areas:

      ./stripes-smart-components/lib/Notes/NoteViewPage/components/NoteView/NoteView.js:251:

      {get(noteData, 'type', '-')}

      ./stripes-smart-components/lib/Notes/NoteViewPage/components/NoteView/NoteView.js:263:

      {get(noteData, 'title', '-')}

      Background

      From Zak: I recently ran across this line:
      value={ get(item, 'status.name', '-')}
      which basically says “use item.status.name if it’s available, or - if it’s not”.

      We have a <NoValue> component that will render this in an a11y-friendly way, but code like that above is more common (100s in platform-core apps, e.g.).

      Acceptance criteria

      • Replace item, status.name '-' with <No Value> component
      • Verify the notes helper does not contain item, status.name '-"

        TestRail: Results

          Attachments

            Issue Links

              Activity

                People

                Assignee:
                Yuliia Dovhal Yuliia Dovhal
                Reporter:
                kgambrell Khalilah Gambrell
                Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                  Dates

                  Created:
                  Updated:
                  Resolved:

                    TestRail: Runs

                      TestRail: Cases