Uploaded image for project: 'Stripes'
  1. Stripes
  2. STRIPES-711

ESLint barfs on ∞ in a transitive dependency

    XMLWordPrintable

Details

    • Bug
    • Status: Closed (View Workflow)
    • TBD
    • Resolution: Done
    • None
    • None
    • None
    • None
    • Core: F - Sprint 101, Core: F - Sprint 102, Core: F - Sprint 103
    • 5
    • Prokopovych

    Description

      yarn lint is failing with errors like the following:

      Error: .eslintrc » @folio/eslint-config-stripes » eslint-config-airbnb » /Users/mike/git/reshare/stripes/node_modules/eslint-config-airbnb-base/index.js » /Users/mike/git/reshare/stripes/node_modules/eslint-config-airbnb-base/rules/imports.js:
      	Configuration for rule "import/no-cycle" is invalid:
      	Value "∞" should be integer.
      

      It appears to be a transitive bug introduced by AirBnb. eslint-config-stripes relies on specific versions, rather than specific version ranges, of its dependencies in order to prevent lint rules from changing unintentionally, including "eslint-plugin-import": "2.18.2" but there must be a ~ or ^ dependency somewhere in that hierarchy that is allowing this updated AirBnb config to sneak in, causing us to need to update to 2.22.1 as well.

      One path is likely updating to 2.22.1 in eslint-config-stripes but we need to see if there are any side-effects when we do that, i.e. unintentional changing of existing lint rules.

      h/t mike who originally reported this on Slack.

      Other interested parties: : Ihor_koba

      TestRail: Results

        Attachments

          Activity

            People

              zburke Zak_Burke
              zburke Zak_Burke
              Votes:
              1 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                TestRail: Runs

                  TestRail: Cases