Uploaded image for project: 'Stripes'
  1. Stripes
  2. STRIPES-426

Address objects in settings via react-router

    XMLWordPrintable

    Details

    • Template:

      Description

      This is an umbrella issue for several module-specific issues to come.

      We use react-router to get into the settings area:
      http://folio-testing.aws.indexdata.com/settings
      And into individual modules' settings areas:
      http://folio-testing.aws.indexdata.com/settings/users
      And into specific pages of a module's settings:
      http://folio-testing.aws.indexdata.com/settings/users/perms

      But once we're in the individual pages, most of them use local state to navigate between specific objects that are being maintained. For example, in the permission-set editor, the same URL (shown above) is used for editing Jakub's Set or Untitled Permission Set or any other set.

      We should use proper routing all the way down, so that we'd have URLs like
      http://folio-testing.aws.indexdata.com/settings/users/perms/Jakub's+set

      Related to this, I worry that we are starting to proliferate settings pages with very similar code. We should look at whether we can abstract out a skeleton that can be customised.

        TestRail: Results

          Attachments

            Issue Links

              Activity

                People

                Assignee:
                mike Mike Taylor
                Reporter:
                mike Mike Taylor
                Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                  Dates

                  Created:
                  Updated:
                  Resolved:

                    Time Tracking

                    Estimated:
                    Original Estimate - Not Specified
                    Not Specified
                    Remaining:
                    Remaining Estimate - 0 minutes
                    0m
                    Logged:
                    Time Spent - 1 day
                    1d

                      TestRail: Runs

                        TestRail: Cases