Details
-
Bug
-
Status: Closed (View Workflow)
-
P2
-
Resolution: Done
-
None
-
None
-
None
-
CP: sprint 114
-
1
-
Core: Platform
Description
Two modules mod-login and mod-permissions were updated to use RMB 33.0.0pre3.
Removing
poolOptions.setIdleTimeout(connectionReleaseDelay);
poolOptions.setIdleTimeoutUnit(TimeUnit.MILLISECONDS);
from PostgresClient.java fixes the problem.
These lines were added in RMB-837.
Using from psql
select client_addr, usename, datname, count(*) from pg_stat_activity group by 1,2,3 order by 4 desc;
to analyze.
Good system (on vagrant box) .. all modules are bound by 5 connections (except Okapi has a much higher limit):
client_addr | usename | datname | count
-------------+------------------------------+---------------+-------
172.17.0.56 | folio_admin | okapi_modules | 10
172.17.0.37 | folio_admin | okapi_modules | 10
172.17.0.51 | folio_admin | okapi_modules | 10
172.17.0.43 | folio_admin | okapi_modules | 10
172.17.0.52 | folio_admin | okapi_modules | 10
172.17.0.15 | diku_mod_inventory_storage | okapi_modules | 5
172.17.0.16 | diku_mod_permissions | okapi_modules | 5
| | | 4
Bad system with mod-permissions using 33.0.0pre3:
client_addr | usename | datname | count
-------------+------------------------------+---------------+-------
10.0.2.15 | diku_mod_permissions | okapi_modules | 11
172.17.0.56 | folio_admin | okapi_modules | 10
172.17.0.37 | folio_admin | okapi_modules | 10
172.17.0.43 | folio_admin | okapi_modules | 10
172.17.0.51 | folio_admin | okapi_modules | 10
172.17.0.52 | folio_admin | okapi_modules | 10
172.17.0.15 | diku_mod_inventory_storage | okapi_modules | 5
172.17.0.16 | diku_mod_permissions | okapi_modules | 5
| | | 4
172.17.0.5 | diku_mod_configuration | okapi_modules | 4
No SQL connection leaks are found when mod-permissions and mod-login are upgraded to Vert.x 4.1.0.Beta1 RMB-839 branch because for 4.1.0.Beta1 a new connection pool was implemented that doesn't leak connections:
- https://github.com/eclipse-vertx/vertx-sql-client/pull/936 "Connection leak when using idle-timeout on PoolOptions" before 4.1.0
- https://github.com/eclipse-vertx/vertx-sql-client/commit/6c3dcdee1a557a9a50a0e7d5903e6507de7cecdd "Test for connection leaks" in 4.1.0
TestRail: Results
Attachments
Issue Links
- relates to
-
-
- Closed
-
-
RMB-837 Upgrade vertx-sql-client to v4.0.3-FOLIO
-
- Closed
-
-
RMB-839 Upgrade to Vert.x 4.1.0.Beta1
-
- Closed
-
-
-
- Closed
-