Uploaded image for project: 'RAML Module Builder'
  1. RAML Module Builder
  2. RMB-817

Remove broken PostgresClient.get(String table, Object entity, ...) methods

    XMLWordPrintable

Details

    • Tech Debt
    • Status: Closed (View Workflow)
    • P3
    • Resolution: Done
    • None
    • 34.0.0
    • CP: sprint 128
    • 1
    • Core: Platform

    Description

      The PostgresClient#get(String table, Object entity, ...) methods are broken since RMB v29.0.0 (RMB-497 https://github.com/folio-org/raml-module-builder/commit/51a67d3b81b372096c11ddcc8e7b0af6db48c744 ) because

      pojo = pojo2json(entity);
      ...
      "@>'" + pojo + "' 

      was removed. The filtering no longer works, the query always returns all records. The unit test doesn't check that the filtering works.

      Since the release of RMB v29.0.0 no one has complained about this bug. This shows that these PostgresClient methods are not in use.

      PostgresClient methods that take a CQLWrapper or a Criteria filter can be used instead.

      Task:

      Remove the methods.

      TestRail: Results

        Attachments

          Issue Links

            Activity

              People

                mikhail.fokanov Mikhail Fokanov
                julianladisch Julian Ladisch
                Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved:

                  TestRail: Runs

                    TestRail: Cases