Uploaded image for project: 'RAML Module Builder'
  1. RAML Module Builder
  2. RMB-591

remove or harmonize 'optimizedSql' execution path

    XMLWordPrintable

Details

    • CP: sprint 86, CP: sprint 85
    • Core: Platform

    Description

      Context

      There are issues with 'optimizedSql' related to hit count estimation – this code path does not use the standard estimation function in RMB but rather hard-codes a high value (99999+).

      This leads to consistency issues raised as one of the problems in MODINVSTOR-468

      Approach

      We discussed two options:

      1. integrate hit count estimation function with the optimizedSql
      2. remove the optimizedSql code path

      2. is preferably as long as there are no performance regressions. This needs to be tested. If there are performance regression approach 2. should be used instead.

      Accepance criteria

      The 'optimizedSql' path should return the same hit count estimation as the standard path.

      This should be verified by sorting by "title" when searching through the /instance-storage/instances records.

      e.g

      /instance-storage/instances/?query=title=xxx sortby title

      should give the same hitcount as 

      /instance-storage/instances/?query=title=xxx sortby title

      Place where sortby title is used:

      https://github.com/folio-org/mod-inventory-storage/blob/891f712a2b72e194d8426d63753ea89b09f5b547/src/main/java/org/folio/rest/impl/InstanceStorageAPI.java#L83

      Performance testing

      Please test the branch before and after changes locally using the guideline from https://wiki.folio.org/display/FOLIJET/Running+performance+test+with+%27platform-perf-test%27+locally

      If the result look good, please merge in RMB and open a PR for mod-inventory-storage. When mod-inventory-storage has been merge please verify the performance using:
      https://jenkins-aws.indexdata.com/job/Automation/job/folio-perf-platform/

      Any performance regressions (especially related to 'sortby title') will require reverting the code.

      TestRail: Results

        Attachments

          Issue Links

            blocks

            Bug - A problem which impairs or prevents the functions of the product. MODINVSTOR-468 hitcount related issues in Q1

            • P2 - normal priority level, must be included in the current development cycle
            • Closed

            Bug - A problem which impairs or prevents the functions of the product. UIIN-1055 Bugfest: Inventory. Sorting by Title gives different result counts than no sort when *searching*

            • P2 - normal priority level, must be included in the current development cycle
            • Closed

            Bug - A problem which impairs or prevents the functions of the product. UIIN-1070 Paused due to POC of Elastic Search. BugFest: Inventory. Search for Term and Filter by Status = Available Always Results in 1,000 Results

            • P3 - low priority level, item will be considered for inclusion in the next dev cycle
            • Closed

            Bug - A problem which impairs or prevents the functions of the product. UIIN-1071 Bugfest: Inventory. Sorting by Title gives different result counts when *filtering* ("More than 10,000 records found" (approximation is not close enough))

            • P2 - normal priority level, must be included in the current development cycle
            • Closed

            Bug - A problem which impairs or prevents the functions of the product. UIIN-1129 SPIKE: JTST Environment. Inventory. Search for Status = Available, Sort by Contributor Gives No Results in Main Pane Despite Result Count of 93,717

            • P2 - normal priority level, must be included in the current development cycle
            • Closed
            is required by

            Bug - A problem which impairs or prevents the functions of the product. UIIN-1055 Bugfest: Inventory. Sorting by Title gives different result counts than no sort when *searching*

            • P2 - normal priority level, must be included in the current development cycle
            • Closed
            relates to

            Task - A task that needs to be done. RMB-573 streamGet with optimized SQL

            • TBD - To be determined
            • Open

            Task - A task that needs to be done. RMB-593 SPIKE: investigate providing high-performance precise hitcount

            • P3 - low priority level, item will be considered for inclusion in the next dev cycle
            • Open

            Bug - A problem which impairs or prevents the functions of the product. RMB-613 optimizedSql performance regression

            • P1 - highest priority item, drop everything else before this is resolved, reserved for critical bugfixes
            • Closed

            New Feature - New feature requests RMB-644 implement generic sort optimization

            • P2 - normal priority level, must be included in the current development cycle
            • Blocked

            Task - A task that needs to be done. MODINVSTOR-215 use sort or search index depending on the result size

            • P2 - normal priority level, must be included in the current development cycle
            • Closed

            Bug - A problem which impairs or prevents the functions of the product. MODINVSTOR-489 InstanceStorageTest fails (hit count related)

            • TBD - To be determined
            • Closed

            Bug - A problem which impairs or prevents the functions of the product. MODINVSTOR-513 hitcount estimation degeneration when upgrading MIS 19.1.2 (fameflower) -> MIS 19.2.0-SNAPSHOT (RMB30)

            • P2 - normal priority level, must be included in the current development cycle
            • Closed

            Bug - A problem which impairs or prevents the functions of the product. RMB-673 totalRecords returns exact hit count for limit=0

            • P2 - normal priority level, must be included in the current development cycle
            • Closed

            Bug - A problem which impairs or prevents the functions of the product. UIIN-1050 Paused due to POC of Elastic Search. SPIKE: Bugfest: Inventory. Item segment. Filtering on Suppress from discovery: Yes and No Don't Add Up (Off by Unacceptable Amount)

            • P3 - low priority level, item will be considered for inclusion in the next dev cycle
            • Closed

            Bug - A problem which impairs or prevents the functions of the product. UIIN-1067 Inventory freezes after 20 Load more-clicks

            • P3 - low priority level, item will be considered for inclusion in the next dev cycle
            • Closed

            Activity

              People

                mikhail.fokanov Mikhail Fokanov
                jakub Jakub Skoczen
                Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved:

                  TestRail: Runs

                    TestRail: Cases