Uploaded image for project: 'RAML Module Builder'
  1. RAML Module Builder
  2. RMB-591

remove or harmonize 'optimizedSql' execution path

    XMLWordPrintable

    Details

    • Template:
    • Sprint:
      CP: sprint 86, CP: sprint 85
    • Development Team:
      Core: Platform

      Description

      Context

      There are issues with 'optimizedSql' related to hit count estimation – this code path does not use the standard estimation function in RMB but rather hard-codes a high value (99999+).

      This leads to consistency issues raised as one of the problems in MODINVSTOR-468

      Approach

      We discussed two options:

      1. integrate hit count estimation function with the optimizedSql
      2. remove the optimizedSql code path

      2. is preferably as long as there are no performance regressions. This needs to be tested. If there are performance regression approach 2. should be used instead.

      Accepance criteria

      The 'optimizedSql' path should return the same hit count estimation as the standard path.

      This should be verified by sorting by "title" when searching through the /instance-storage/instances records.

      e.g

      /instance-storage/instances/?query=title=xxx sortby title

      should give the same hitcount as

      /instance-storage/instances/?query=title=xxx sortby title

      Place where sortby title is used:

      https://github.com/folio-org/mod-inventory-storage/blob/891f712a2b72e194d8426d63753ea89b09f5b547/src/main/java/org/folio/rest/impl/InstanceStorageAPI.java#L83

      Performance testing

      Please test the branch before and after changes locally using the guideline from https://wiki.folio.org/display/FOLIJET/Running+performance+test+with+%27platform-perf-test%27+locally

      If the result look good, please merge in RMB and open a PR for mod-inventory-storage. When mod-inventory-storage has been merge please verify the performance using:
      https://jenkins-aws.indexdata.com/job/Automation/job/folio-perf-platform/

      Any performance regressions (especially related to 'sortby title') will require reverting the code.

        TestRail: Results

          Attachments

            Issue Links

              Activity

                People

                Assignee:
                mikhail.fokanov Mikhail Fokanov
                Reporter:
                jakub Jakub Skoczen
                Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                  Dates

                  Created:
                  Updated:
                  Resolved:

                    TestRail: Runs

                      TestRail: Cases