Uploaded image for project: 'Okapi'
  1. Okapi
  2. OKAPI-968

Unhandled exception in DockerModuleHandle.request

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: TBD
    • Resolution: Done
    • Affects Version/s: 4.5.2
    • Fix Version/s: 4.5.3, 4.6.0
    • Labels:
      None
    • Template:
      Standard Bug Write-Up Format
    • Story Points:
      0.5
    • Development Team:
      Core: Platform
    • Affected Institution:
      GBV

      Description

      Vert.x HttpClient.request doesn't return all exceptions as a failed future but also directly throws some exceptions.

      Example:

      2020-12-18T22:03:31,099 INFO  DockerModuleHandle   delete container 8ee1e1ec95ecc311d7d603a4d5871ac17dd67c860a48f613ce0c7199e4e4c59b image folioci/mod-gobi:1.
      8.0-SNAPSHOT.98
      2020-12-18T22:03:31,102 ERROR ?                    Unhandled exception
      java.lang.IllegalStateException: Client is closed
              at io.vertx.core.http.impl.HttpClientImpl.checkClosed(HttpClientImpl.java:634) ~[okapi-core-fat.jar:?]
              at io.vertx.core.http.impl.HttpClientImpl.request(HttpClientImpl.java:542) ~[okapi-core-fat.jar:?]
              at io.vertx.core.http.impl.HttpClientImpl.request(HttpClientImpl.java:396) ~[okapi-core-fat.jar:?]
              at io.vertx.core.http.impl.HttpClientImpl.request(HttpClientImpl.java:391) ~[okapi-core-fat.jar:?]
              at org.folio.okapi.service.impl.DockerModuleHandle.request(DockerModuleHandle.java:145) ~[okapi-core-fat.jar:?]
              at org.folio.okapi.service.impl.DockerModuleHandle.deleteUrl(DockerModuleHandle.java:159) ~[okapi-core-fat.jar:?]
              at org.folio.okapi.service.impl.DockerModuleHandle.deleteContainer(DockerModuleHandle.java:175) ~[okapi-core-fat.jar:?]
              at org.folio.okapi.service.impl.DockerModuleHandle.lambda$prepareContainer$18(DockerModuleHandle.java:430) ~[okapi-core-fat.jar:?]
      

      Task:
      Catch them and pass them as a failed future.

        TestRail: Results

          Attachments

            Issue Links

              Activity

                People

                Assignee:
                julianladisch Julian Ladisch
                Reporter:
                julianladisch Julian Ladisch
                Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                  Dates

                  Created:
                  Updated:
                  Resolved:

                    TestRail: Runs

                      TestRail: Cases