Uploaded image for project: 'Okapi'
  1. Okapi
  2. OKAPI-884

% variable expansion in env breaks credentials

    XMLWordPrintable

Details

    • Standard Bug Write-Up Format
    • CP: sprint 96
    • 1.5
    • Core: Platform
    • Q3 2020

    Description

      Set DB_PASSWORD to a value that contains %p and/or %c:

      curl -w '\n' -D - -d '{"name":"DB_PASSWORD","value":"uvwxyz%p%c"}' http://localhost:9130/_/env
      

      https://github.com/folio-org/okapi/blob/v4.1.0/okapi-core/src/main/java/org/folio/okapi/service/impl/DockerModuleHandle.java#L320
      replaces %p by hostPort and %c by containerHost. This breaks the credentials, PostgreSQL login fails.

      The spec is in the guide: https://github.com/folio-org/okapi/blob/master/doc/guide.md#deployment

      The port is passed as %p in the value of properties exec and cmdlineStart.

      The value of containerHost can be referred to as %c in dockerArgs of the deployment.

      Task:
      Replace % variables in exec, cmdlineStart and dockerArgs values only.

      TestRail: Results

        Attachments

          Activity

            People

              julianladisch Julian Ladisch
              julianladisch Julian Ladisch
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                TestRail: Runs

                  TestRail: Cases