Details
-
Bug
-
Status: Closed (View Workflow)
-
P3
-
Resolution: Done
-
3.3.1
-
-
eHoldings Sprint 107
-
2
-
Spitfire
Description
When attempting to import a user without a requestPreference, mod-user-import will attempt to DELETE existing request preferences even if updateOnlyPresentFields is set to true.
To replicate:
1. Create a user manually with preferences so that the request preferences entry is created.
2. Fire off an import containing info about that user. Eg,
{ "users": [ { "username": "md331@duke.edu", "externalSystemId": "12345", "active": true, "patronGroup": "Staff" } ], "deactivateMissingUsers": false, "totalRecords": 1, "updateOnlyPresentFields": true }
3. Note the response contains a failedUsers entry. Eg,
{ "username": "md331@duke.edu", "externalSystemId": "12345", "errorMessage": "Failed to delete user preference.Failed to decode:Cannot construct instance of `java.util.LinkedHashMap` (although at least one Creator exists): no String-argument constructor/factory method to deserialize from String value ('159c0f18-85ba-417e-a705-7306adc6416d')\n at [Source: (String)\"\"159c0f18-85ba-417e-a705-7306adc6416d\"\"; line: 1, column: 1]" }
Now, obviously there shouldn't be an error if we are trying to delete the request preference. That's bug #1. But bug #2 is that the code should definitely not unconditionally attempt to delete the request preference if it's nullish, as it does here. It should be checking the value of updateOnlyPresentFields.
TestRail: Results
Attachments
Issue Links
- is duplicated by
-
MODUIMP-50 User can not be updated in bulk update after record has been modified in UI
-
- Closed
-
- relates to
-
MODUIMP-13 Support loading of Delivery request fields via mod-user-import
-
- Closed
-
-
UXPROD-2723 R1 2021 | Spitfire Tech Debt
-
- Closed
-
-
UXPROD-2873 Mod-user-import stabilization
-
- Open
-