Uploaded image for project: 'mod-rtac'
  1. mod-rtac
  2. MODRTAC-38

For 1 User Rtac takes ~15 seconds to get holdings record with open loans

    XMLWordPrintable

Details

    • Bug
    • Status: Closed (View Workflow)
    • P2
    • Resolution: Done
    • None
    • 2.0.0
    • None
    • Q3 scope, Gulfstream Sprint 95, Gulfstream Sprint 96, Gulfstream Sprint 97
    • 8
    • Gulfstream

    Description

      Overview:
      Steps to Reproduce:
      Log into performance environment FOLIO environment as folio user
      Make GET rtac/instanceId where each instance has more than 300 holdings record

      Expected Results: getRtacById method is O(n^3)
      Actual Results: getRtacById is O( n )

      Additional Information:
      The main issue is with https://github.com/folio-org/mod-rtac/blob/d8e51a8a82b69a6f1717b9c7abf60342ded99246/src/main/java/org/folio/rest/impl/RtacResourceImpl.java#L48
      Even after leveraging vertx's asynchronous behavior and considering the fact that 1 instance -> many holdings -> each holding -> many items -> each item -> many loans, this call chain triggers Big O(n^3) or Big O(holdings * items * loans) algorithmic complexity.

      https://issues.folio.org/browse/PERF-61

      URL:
      https://wiki.folio.org/pages/viewpage.action?pageId=36579550

      The goal is to get RTAC execution to below 5 seconds for more than 300 holdings.

      Interested parties:
      All consumers of mod-rtac

      TestRail: Results

        Attachments

          Issue Links

            blocks

            Story - Created by Jira Software - do not edit or delete. Issue type for a user story. MODRTAC-37 Better handle periodicals in response

            • P1 - highest priority item, drop everything else before this is resolved, reserved for critical bugfixes
            • Closed
            defines

            New Feature - New feature requests UXPROD-2425 RTAC | Holdings - EDGE-RTAC and MOD-RTAC API updates

            • P3 - low priority level, item will be considered for inclusion in the next dev cycle
            • Closed
            is blocked by

            Story - Created by Jira Software - do not edit or delete. Issue type for a user story. MODINVSTOR-518 Transform OAI-PMH view API in Inventory into general API

            • P2 - normal priority level, must be included in the current development cycle
            • Closed
            is required by

            Story - Created by Jira Software - do not edit or delete. Issue type for a user story. EDGRTAC-29 REST batching support

            • P2 - normal priority level, must be included in the current development cycle
            • Closed
            relates to

            Bug - A problem which impairs or prevents the functions of the product. MODINVSTOR-614 inventory-storage crashes after grabbing all available DB connections

            • P1 - highest priority item, drop everything else before this is resolved, reserved for critical bugfixes
            • Closed

            Story - Created by Jira Software - do not edit or delete. Issue type for a user story. MODRTAC-34 REST batching support

            • P2 - normal priority level, must be included in the current development cycle
            • Closed

            Task - A task that needs to be done. MODRTAC-40 [SPIKE] Measurement of time penalty for additional proxification

            • P3 - low priority level, item will be considered for inclusion in the next dev cycle
            • Closed

            Bug - A problem which impairs or prevents the functions of the product. EDGRTAC-33 Memory leak of ~200mb for /rtac?instanceIds=id1,id2,idn API

            • P2 - normal priority level, must be included in the current development cycle
            • Closed

            Story - Created by Jira Software - do not edit or delete. Issue type for a user story. MODINVSTOR-534 Create database view for RTAC performance optimization

            • P2 - normal priority level, must be included in the current development cycle
            • Closed

            Bug - A problem which impairs or prevents the functions of the product. MODRTAC-48 Issues in batch API when querying an instance with more than 50 holdings

            • P1 - highest priority item, drop everything else before this is resolved, reserved for critical bugfixes
            • Closed

            Bug - A problem which impairs or prevents the functions of the product. MODRTAC-53 Folio facade mapping error - 504

            • P3 - low priority level, item will be considered for inclusion in the next dev cycle
            • Open

            Bug - A problem which impairs or prevents the functions of the product. MODRTAC-64 RTAC-batch: Wrong response for not-existing instance

            • P2 - normal priority level, must be included in the current development cycle
            • Closed

            Story - Created by Jira Software - do not edit or delete. Issue type for a user story. PERF-61 Rerun RTAC tests

            • P2 - normal priority level, must be included in the current development cycle
            • Closed
            requires

            Story - Created by Jira Software - do not edit or delete. Issue type for a user story. PERF-117 Test mod-rtac (Honeysuckle)

            • P2 - normal priority level, must be included in the current development cycle
            • Closed
            mentioned in

            Page Loading...

            Activity

              People

                varunjavalkar Varun Javalkar
                varunjavalkar Varun Javalkar
                Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved:

                  TestRail: Runs

                    TestRail: Cases