Uploaded image for project: 'mod-remote-storage'
  1. mod-remote-storage
  2. MODRS-20

Accessions API doesn't work with compound query

    XMLWordPrintable

Details

    • Bug
    • Status: Closed (View Workflow)
    • P2
    • Resolution: Done
    • None
    • 1.0.0
    • None
    • Firebird Sprint 108
    • 1
    • Firebird

    Description

      Overview:

      edge-dematic should call mod-remote-storage API with compound queries for accessions and retrievals, i.e.

      /remote-storage/accessions?accessioned=false&remoteStorageId=de17bad7-2a30-4f1c-bee5-f653ded15624
      /remote-storage/retrievals?retrieved=false&remoteStorageId=de17bad7-2a30-4f1c-bee5-f653ded15624
      

      Steps to Reproduce:

      1. Retrieve all accession queue records:
        GET /remote-storage/accessions HTTP/1.1
        x-okapi-token: $TOKEN
        x-okapi-tenant: diku
        x-okapi-url: http://localhost:9130
        User-Agent: PostmanRuntime/7.26.8
        Accept: */*
        Postman-Token: d169127e-e144-4cca-b01d-88cc6880756c
        Host: localhost:9130
        Accept-Encoding: gzip, deflate, br
        Connection: keep-alive
        HTTP/1.1 200 OK
        vary: origin
        Content-Type: application/json
        Date: Sun, 21 Feb 2021 13:28:32 GMT
        Keep-Alive: timeout=60
        Connection: keep-alive
        transfer-encoding: chunked
        X-Okapi-Trace: GET mod-remote-storage-1.1.0-SNAPSHOT http://10.0.2.2:8082/remote-storage/accessions : 200 1748102us
        {"totalRecords":2,"accessions":[{"id":"0f74145b-6900-4a4f-8e71-4c965e601495","itemBarcode":"453987605438","createdDateTime":"2021-02-16T17:24:08.761+00:00","accessionedDateTime":"2021-02-21T16:14:06.731+00:00","remoteStorageId":"de17bad7-2a30-4f1c-bee5-f653ded15629","callNumber":"PR6056.I4588 B749 2016","instanceTitle":"title","instanceAuthor":"author"},{"id":"022951cb-09a5-44fe-8438-eb74a0a8b1aa","itemBarcode":"697685458679","createdDateTime":"2021-02-21T16:07:24.471+00:00","remoteStorageId":"de17bad7-2a30-4f1c-bee5-f653ded15629","callNumber":"some-callnumber","instanceTitle":"Nod","instanceAuthor":"Barnes, Adrian"}]}
        
      1. Retrieve not accessioned records:
        GET /remote-storage/accessions?accessioned=false HTTP/1.1
        x-okapi-token: $TOKEN
        x-okapi-tenant: diku
        x-okapi-url: http://localhost:9130
        User-Agent: PostmanRuntime/7.26.8
        Accept: */*
        Postman-Token: e7b6c810-65fc-45d0-861d-e8512b3f99c0
        Host: localhost:9130
        Accept-Encoding: gzip, deflate, br
        Connection: keep-alive
        HTTP/1.1 200 OK
        vary: origin
        X-Okapi-Trace: GET mod-authtoken-2.7.0-SNAPSHOT.81 http://10.0.2.15:9131/remote-storage/accessions.. : 202 6531590us
        X-Okapi-Trace: GET mod-remote-storage-1.1.0-SNAPSHOT http://10.0.2.2:8082/remote-storage/accessions.. : 200 2144881us
        Content-Type: application/json
        Date: Sun, 21 Feb 2021 13:32:11 GMT
        Keep-Alive: timeout=60
        Connection: keep-alive
        transfer-encoding: chunked
        {"totalRecords":2,"accessions":[{"id":"0f74145b-6900-4a4f-8e71-4c965e601495","itemBarcode":"453987605438","createdDateTime":"2021-02-16T17:24:08.761+00:00","accessionedDateTime":"2021-02-21T16:14:06.731+00:00","remoteStorageId":"de17bad7-2a30-4f1c-bee5-f653ded15629","callNumber":"PR6056.I4588 B749 2016","instanceTitle":"title","instanceAuthor":"author"},{"id":"022951cb-09a5-44fe-8438-eb74a0a8b1aa","itemBarcode":"697685458679","createdDateTime":"2021-02-21T16:07:24.471+00:00","remoteStorageId":"de17bad7-2a30-4f1c-bee5-f653ded15629","callNumber":"some-callnumber","instanceTitle":"Nod","instanceAuthor":"Barnes, Adrian"}]}
        

        ERROR - the only records without accessioned date-time should be returned. So the filtration for accessioned=false should be added.

       

      TestRail: Results

        Attachments

          Issue Links

            Activity

              People

                khandramai Viachaslau Khandramai
                khandramai Viachaslau Khandramai
                Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved:

                  TestRail: Runs

                    TestRail: Cases