Uploaded image for project: 'mod-pubsub'
  1. mod-pubsub
  2. MODPUBSUB-202

Bad HTTP client pool utilitization in mod-pubsub-client

    XMLWordPrintable

Details

    • Bug
    • Status: Closed (View Workflow)
    • P3
    • Resolution: Done
    • None
    • 2.5.0
    • None
    • EPAM-Veg Sprint 133
    • 5
    • Vega
    • Lotus R1 2022

    Description

      mod-pubsub-client uses a modified version of the PubsubClient class. It's normally
      generated by RMB, but with MODPUBSUB-127 MODPUBSUB-133 it has its own copy.

      https://github.com/folio-org/mod-pubsub/blob/6aea9a028345a97c71f619b5382e88bed3f47a28/mod-pubsub-client/src/main/java/org/folio/rest/client/PubsubClient.java#L20

      Changing generated code and hope it still works is slightly suboptimal, as RMB has evolved since the paste's n copy.. In particular RMB has offered new constructors for its generated client. RMB-796 RMB-783

      At this stage mod-pubsub creates a HTTP pool for each PubsubClient usage and closes the pool afterwards.. A pool that has one HTTP socket at most.

      https://github.com/folio-org/mod-pubsub/blob/6aea9a028345a97c71f619b5382e88bed3f47a28/mod-pubsub-client/src/main/java/org/folio/util/pubsub/PubSubClientUtils.java#L63-L78

      A proper solution is to use one HttpClient or WebClient per Vert.x instance (which normally is just 1 in a module). Then use that for all HTTP communications.. Then sockets can be reused between each request, thus, resulting in faster HTTP operations.

      The, now, obsolete version of PubsubClient.java should be removed and RMB's generated version be used instead.

      While the mod-pubsub-client artifact is included in several projects, PubsubClient is only used in mod-pubsub-client itself and mod-remote-storage.

      https://github.com/search?q=org%3Afolio-org+PubsubClient&type=code

      TestRail: Results

        Attachments

          Issue Links

            relates to

            Bug - A problem which impairs or prevents the functions of the product. MODPUBSUB-127 HttpClientImpl instances created by PubSubClient are not closed explicitly

            • P1 - highest priority item, drop everything else before this is resolved, reserved for critical bugfixes
            • Closed

            Bug - A problem which impairs or prevents the functions of the product. MODPUBSUB-133 BackPort - HttpClientImpl instances created by PubSubClient are not closed explicitly

            • P1 - highest priority item, drop everything else before this is resolved, reserved for critical bugfixes
            • Closed

            New Feature - New feature requests RMB-796 ClientGenerator: add new HttpClient constructor, explain "close"

            • P2 - normal priority level, must be included in the current development cycle
            • Closed

            Bug - A problem which impairs or prevents the functions of the product. MODPUBSUB-201 socket leak for outgoing HTTP requests

            • P1 - highest priority item, drop everything else before this is resolved, reserved for critical bugfixes
            • Closed

            Bug - A problem which impairs or prevents the functions of the product. MODPUBSUB-203 R2/Juniper -- socket leak for outgoing HTTP requests

            • P1 - highest priority item, drop everything else before this is resolved, reserved for critical bugfixes
            • Closed

            Activity

              People

                sherzod_nurjonov Sherzod Nurjonov
                adam Adam Dickmeiss (Inactive)
                Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved:

                  TestRail: Runs

                    TestRail: Cases