Uploaded image for project: 'mod-patron-blocks'
  1. mod-patron-blocks
  2. MODPATBLK-101

Update module descriptor for optimistic locking

    XMLWordPrintable

Details

    • CP: sprint 123
    • Core: Platform

    Description

      Overview:
      mod-patron-blocks's ModuleDescriptor likely needs to be updated based on changes from optimistic locking on snapshot. 
      Steps to Reproduce:

      1. Clone the FAT repo: https://github.com/folio-org/folio-integration-tests
      2. Check out this branch: https://github.com/folio-org/folio-integration-tests/tree/core-platform-team-optimistic-locking
      3. Run the following command: ./runtests.sh mod-patron-blocks scratch
      4. Look in the logs for a request like this (not this exact request since the tenant will be auto generated): https://core-platform-okapi.ci.folio.org:443/_/proxy/tenants/testenant1033762027491197952/install?tenantParameters=loadSample%3Dfalse%2CloadReference%3Dfalse

      The okapi error returned is:

      Incompatible version for module mod-inventory-17.1.0-coreplatform.1 interface
      item-storage. Need 8.9. Have 9.0/mod-inventory-storage-22.0.0-coreplatform.1.

      Incompatible version for module mod-inventory-17.1.0-coreplatform.1 interface
      instance-storage. Need 7.8. Have 8.0/mod-inventory-storage-22.0.0-coreplatform.1.

      Incompatible version for module mod-inventory-17.1.0-coreplatform.1 interface
      instance-storage-batch. Need 0.2. Have 1.0/mod-inventory-storage-22.0.0-coreplatform.1.

      Incompatible version for module mod-inventory-17.1.0-coreplatform.1 interface
      holdings-storage. Need 2.0 3.0 4.0. Have 5.0/mod-inventory-storage-22.0.0-coreplatform.1

      I believe that adding version 7.1 to the loan-storage requires section here should fix this: https://github.com/folio-org/mod-patron-blocks/blob/3ada566e382a95ba59ab9db0b5933dcde29a70a8/descriptors/ModuleDescriptor-template.json#L19

      Expected Results:
      mod-patron-blocks should be registered without an error.
      Actual Results:
      Okapi returns 422.
      Additional Information:
      This is part of the work the CP team is doing to test optimistic locking.
      Interested parties:
      julianladisch , Hanna_Hulevich@epam.com 

      TestRail: Results

        Attachments

          Issue Links

            Activity

              People

                stevel Steve Ellis
                stevel Steve Ellis
                Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved:

                  TestRail: Runs

                    TestRail: Cases