Uploaded image for project: 'mod-orders'
  1. mod-orders
  2. MODORDERS-708

Update total validation

    XMLWordPrintable

Details

    • ACQ Sprint 143, ACQ Sprint 144
    • 3
    • Thunderjet
    • Morning Glory R2 2022 Bug Fix
    • Hide
      Use a dollar amount for at least one of your fund distributions such that the system will not encounter a rounding error. ie. for $90 use 33.33%, 33.33% and $33.34. This ensures the total after rounding up or down is in fact $90 and not $89.991 resulting in 1 penny missing.
      Show
      Use a dollar amount for at least one of your fund distributions such that the system will not encounter a rounding error. ie. for $90 use 33.33%, 33.33% and $33.34. This ensures the total after rounding up or down is in fact $90 and not $89.991 resulting in 1 penny missing.
    • !!!ALL!!!
    • Legitimate regression

    Description

      Overview: When using only dollar amount distributions the system doesn't acknowledge that all cost in accounted for and order will not open.
      Fund distribution total validation should allow 2 cases: either totals in the currency add up, or percentages add up to 100%. Currently the first case is not supported (it used to be the only one supported before MODORDERS-482).

      Steps to Reproduce:

      1. Log into some FOLIO environment as User X
      2. Create order
      3. Add order line with cost of $90
      4. Add 3 fund distributions using percentage
      5. Each Fund 33.33%
      6. Save POL
      7. Click action menu for order
      8. Click Open

      Expected Results: Order is opened and encumbered successfully. Three encumbrances, 1 for each fund for $30

       
      Actual Results: Order fails to open. error shown "Fund distribution total must add to 100% or totalPrice"

      Approach
      New API should be created.
      Please take a look -> UIOR-988 Create API contract for fund distribution validation
      File with APIs -> fundValidationAPIContract.txt

      • Reuse: org.folio.orders.utils.FundDistributionUtils#validateFundDistributionTotal

      Additional Information: This was found in bugfest lotus release.

      The new implementation should be callable directly by UI in a new endpoint. See UIOR-988.

      URL:

      Interested parties:

      TestRail: Results

        Attachments

          Issue Links

            Activity

              People

                Nosko Serhii Nosko
                damieng Damien Guillaume
                Dennis Bridges Dennis Bridges
                Votes:
                0 Vote for this issue
                Watchers:
                9 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved:

                  TestRail: Runs

                    TestRail: Cases