Uploaded image for project: 'mod-orders'
  1. mod-orders
  2. MODORDERS-662

Fix randomly failing tests

    XMLWordPrintable

Details

    • Tech Debt
    • Status: Closed (View Workflow)
    • TBD
    • Resolution: Done
    • None
    • 12.4.0
    • None
    • ACQ Sprint 138, ACQ Sprint 139
    • 1
    • Thunderjet
    • Morning Glory R2 2022
    • TBD

    Description

      Purpose/Overview:

      Some integration tests for mod-orders have been failing randomly for months. We should fix the tests or fix mod-orders.

      • MODORDERS-538-piece-against-non-package-mixed-pol-manual-piece-creation-is-false

      >>> failed features:
      match failed: EQUALS
      $ | not equal (NUMBER:NUMBER)
      4
      3

      classpath:thunderjet/mod-orders/features/MODORDERS-538-piece-against-non-package-mixed-pol-manual-piece-creation-is-false.feature:410
      match failed: EQUALS
      $ | not equal (NUMBER:NUMBER)
      3
      2

      classpath:thunderjet/mod-orders/features/MODORDERS-538-piece-against-non-package-mixed-pol-manual-piece-creation-is-false.feature:465
      <<<

      • MODORDERS-579-update-piece-against-non-package-mixed-pol-manual-piece-creation-is-false

      >>> failed features:
      match failed: EQUALS
      $ | actual array length is 2 (LIST:STRING)
      [

      {"quantity":1,"quantityElectronic":1,"holdingId":"59e2c91d-d1dd-4e1a-bbeb-67e8b4dcd111"}

      ,

      {"quantityPhysical":1,"quantity":1,"holdingId":"f16beffd-79ec-46d5-bfc4-504301497ce8"}

      ]
      '#[1]'

      classpath:thunderjet/mod-orders/features/MODORDERS-579-update-piece-against-non-package-mixed-pol-manual-piece-creation-is-false.feature:311
      match failed: EQUALS
      $ | not equal (STRING:STRING)
      '542d918e-0747-4c36-bb51-542e2b230584'
      '600eaa68-ecce-4308-9fb2-2f9c18303592'

      classpath:thunderjet/mod-orders/features/MODORDERS-579-update-piece-against-non-package-mixed-pol-manual-piece-creation-is-false.feature:442
      <<<

      • MODORDERS-580-update-piece-POL-location-not-updated-when-piece-location-edited-against-non-package

      >>> failed features:
      match failed: EQUALS
      $ | not equal (NUMBER:NUMBER)
      2
      1

      classpath:thunderjet/mod-orders/features/MODORDERS-580-update-piece-POL-location-not-updated-when-piece-location-edited-against-non-package.feature:178
      <<<

      • check-order-re-encumber-work-correctly

      >>> failed features:
      match failed: EQUALS
      $ | not equal (NUMBER:NUMBER)
      0.61
      0.6

      classpath:thunderjet/mod-orders/features/check-order-re-encumber-work-correctly.feature:459
      <<<

      Requirements/Scope:

      Fix the tests or mod-orders.

      Approach:

      Tests seem to fail more often when mod-orders is executed in IDEA.

      The last issue looks like an error in the test. The 2 returned transactions are not always in the same order. The fromFundId property could be used to determine which one is the first one. Fund ids are given in the "prepare order lines with orderLineId <poLineId>" scenario.

      Acceptance criteria:

      • mod-orders integration tests all pass consistently

      TestRail: Results

        Attachments

          Issue Links

            Activity

              People

                Andrei_Makaranka Andrei Makaranka
                damieng Damien Guillaume
                Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved:

                  TestRail: Runs

                    TestRail: Cases