Uploaded image for project: 'mod-orders'
  1. mod-orders
  2. MODORDERS-609

Deleting an order line fails without mod-invoice

    XMLWordPrintable

    Details

    • Template:
      Thunderjet/Firebird Back-end Story Template
    • Sprint:
      ACQ Sprint 129
    • Story Points:
      1
    • Development Team:
      Thunderjet
    • Release:
      Lotus R1 2022

      Description

      Purpose/Overview:

      Mod-orders should not depend on mod-invoice for basic operations, but:

      DELETE /orders/order-lines/{{orderLineId}}

      returns the error:

      "No suitable module found for path /invoice/invoice-lines for tenant diku"

      This is caused by PurchaseOrderLineHelper#deleteLine calling PurchaseOrderLineHelper#verifyDeleteAllowed calling OrderInvoiceRelationService#checkOrderPOLineLinkedToInvoiceLine.

      Requirements/Scope:

      Ensure that deleting an order line can be done without mod-invoice installed.

      Approach:

      In checkOrderPOLineLinkedToInvoiceLine(), check that the order is linked to some invoice with getOrderInvoiceRelationshipCollection() before proceeding with the invoice line query. Return right away if there is no relationship.

      Acceptance criteria:

      • Test with Postman (Karate tests for mod-orders might include mod-invoice)

        TestRail: Results

          Attachments

            Issue Links

              Activity

                People

                Assignee:
                Andrei_Makaranka Andrei Makaranka
                Reporter:
                damieng Damien Guillaume
                Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                  Dates

                  Created:
                  Updated:
                  Resolved:

                    TestRail: Runs

                      TestRail: Cases