Uploaded image for project: 'mod-orders'
  1. mod-orders
  2. MODORDERS-598

Replace CompletableFuture.allOf with FolioVertxCompletableFuture.allOf

    XMLWordPrintable

    Details

    • Type: Tech Debt
    • Status: Open (View Workflow)
    • Priority: P3
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Template:
      Standard Bug Write-Up Format
    • Development Team:
      Thunderjet

      Description

      Overview:
      Why can't you use Completable Future with Vert.x : https://github.com/cescoffier/vertx-completable-future

      • If you use the non “async” method, and the completion of the future happen in the vert.x context, you are fine.
      • If you use an async method with an executor executing in a Vert.x context, you are fine
      • If you use an async method on a regular completable future, you are not fine as you are using a fork/join thread pool
      • If you use an async method on the Vert.x completable future of https://github.com/cescoffier/vertx-completable-future, you are fine as you pass the context your want when creating the VertxCompletableFuture.

      Steps to Reproduce:

      1. Run API which uses CompletableFuture.allOf

      Approach
      Replace all places CompletableFuture.allOf with FolioVertxCompletableFuture.allOf

      Expected Results:
      Actual Results:
      Additional Information:
      URL:
      Interested parties:

        TestRail: Results

          Attachments

            Activity

              People

              Assignee:
              Unassigned Unassigned
              Reporter:
              Andrei_Makaranka Andrei Makaranka
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Dates

                Created:
                Updated:

                  TestRail: Runs

                    TestRail: Cases