Details
-
Story
-
Status: Open (View Workflow)
-
TBD
-
Resolution: Unresolved
-
None
-
None
-
-
Thunderjet
Description
Purpose/Overview:
This issue does not seem to affect the UI, as order line updates are currently using the /orders/order-lines/{id} path for cost or fund distribution changes. So this is not a very high priority, but there are users taking advantage of the API who could be affected.
The API allows editing an order with the /orders/composite-orders/{id} path, including the order line costs and fund distributions. No error is returned if they are modified.
The issue is that encumbrances do not get updated when the order is modified this way, or when a fund distribution is deleted.
Requirements/Scope:
Order line changes via the whole composite order should affect budget encumbrances in the same way as direct order line updates.
Approach:
Code should be shared somehow between order line updates and composite order updates affecting the lines, to make sure they keep consistent in the future.
Acceptance criteria:
- The attached karate test should pass
- More unit tests should be added