Uploaded image for project: 'mod-orders'
  1. mod-orders
  2. MODORDERS-262

PO with a POL whose productID has a paren, copied/edited from Instance cannot be saved

    XMLWordPrintable

Details

    • ACQ Sprint 74
    • 1
    • Thunderjet

    Description

      Overview: If you create a POL with data from an Inventory Instance but then change that data such that the UUID is wiped out, but the data has a Product ID containing a parenthesis, then you cannot save/open the PO

      Steps to Reproduce:

      1. Log into FOLIO-snapshot as diku_admin
      2. Go to the order app
      3. Create a PO
      4. Create a POL and populate the bib data from an Inventory Instance ("accidental atheist" title)
      5. Remove a contributor, or edit the title slightly, which should make the Instance UUID disappear
      6. Save the POL
      7. Open the PO

      Expected Results: The PO should Open

      Actual Results: There's a message "PO cannot be saved".

      Additional Information: See attached video. From piotr_kalashuk in the comments: Looks like parentheses in the productId should be somehow be escaped when building CQL query to inventory storage.

      TestRail: Results

        Attachments

          1. accidental_atheist_instance.png
            accidental_atheist_instance.png
            60 kB
          2. InventoryIdentifierWithParentheses.png
            InventoryIdentifierWithParentheses.png
            135 kB
          3. Inventory with paren.PNG
            Inventory with paren.PNG
            177 kB
          4. OpenOrderWithParenthesis.png
            OpenOrderWithParenthesis.png
            236 kB
          5. PO cannot be saved.mp4
            4.39 MB
          6. POL with paren.PNG
            POL with paren.PNG
            170 kB
          7. ProductIdWithParenthesisSearch.png
            ProductIdWithParenthesisSearch.png
            120 kB
          8. Try to open this one.PNG
            Try to open this one.PNG
            147 kB

          Issue Links

            has to be done after

            Story - Created by Jira Software - do not edit or delete. Issue type for a user story. MODORDERS-310 Update mod-orders to use the new version of the schema with qualifier field

            • P3 - low priority level, item will be considered for inclusion in the next dev cycle
            • Closed

            Story - Created by Jira Software - do not edit or delete. Issue type for a user story. UIOR-392 Move ISBN Qualifier to separate field in UI Create/Edit screen

            • P2 - normal priority level, must be included in the current development cycle
            • Closed
            is blocked by

            Bug - A problem which impairs or prevents the functions of the product. MODINVSTOR-293 CQL identifiers=")" fails with "invalid regular expression: parentheses () not balanced" SQL Injection

            • P2 - normal priority level, must be included in the current development cycle
            • Closed

            Bug - A problem which impairs or prevents the functions of the product. RMB-396 mask ) ] } in regexp to prevent SQL injection

            • TBD - To be determined
            • Closed
            relates to

            Bug - A problem which impairs or prevents the functions of the product. UIIN-569 Search for titles with value with parenthesis results in error messages when search term: All (title, contributor, identifier)

            • P2 - normal priority level, must be included in the current development cycle
            • Closed

            Story - Created by Jira Software - do not edit or delete. Issue type for a user story. UIOR-228 Capture instance uuid and product id's when user selects instance

            • P3 - low priority level, item will be considered for inclusion in the next dev cycle
            • Closed

            Activity

              People

                varunjavalkar Varun Javalkar
                abreaux Ann-Marie Breaux
                Craig McNally Craig McNally
                Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved:

                  TestRail: Runs

                    TestRail: Cases