Uploaded image for project: 'mod-orders'
  1. mod-orders
  2. MODORDERS-247

Make contributor-name-type configurable

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Closed (View Workflow)
    • Priority: P3
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: 7.0.0
    • Labels:
      None
    • Template:
    • Sprint:
      ACQ Sprint 65, ACQ Sprint 67
    • Story Points:
      2
    • Development Team:
      Thunderjet

      Description

      Overview

      Currently we've hardcoded the contributor-name-type to name: "Personal name" which is present in the inventory reference data (see MODORDERS-204). However, there's no guarantee that the reference data will be loaded/used by all tenants. As a result, we need to allow the tenant to specify which contributor-name-type they want to use when creating instances upon order placement.

      Approach

      There are 2 possible approaches:

      1. contributor.json has 2 properties: contributor (any string) which is used by UI and contributorType (UUID of the type record) which is not in use. The option is to rename contributorType to contributorNameTypeId making it required and let UI to specify it i.e. an user should explicitly select one
      2. When creating instances, check mod-configuration for the contributor-name-type specified. If a value is not configured, check if Personal name exists. If it does, use that, if not, return an appropriate error message/code

      NOTE: We also need to validate that the contributorType exists. If not return an appropriate error (code and message)

      Acceptance Criteria

      • contributorType is renamed to contributorNameTypeId and made required in the schemas
      • The provided contributorNameTypeId uuid is used
      • validate that the provided contributorNameTypeId actually exists and return an appropriate error (code & message) if it doesn't
      • Unit tests are updated
      • API tests are updated

        TestRail: Results

          Attachments

            Issue Links

              Activity

                People

                Assignee:
                KVupp Kruthi Vuppala
                Reporter:
                piotr_kalashuk Piotr Kalashuk
                Tester Assignee:
                Craig McNally Craig McNally
                Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                  Dates

                  Created:
                  Updated:
                  Resolved:

                    TestRail: Runs

                      TestRail: Cases