Uploaded image for project: 'mod-oai-pmh'
  1. mod-oai-pmh
  2. MODOAIPMH-179

log4j.properties being included in fat jar, not log4j2.properties

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: P2
    • Resolution: Done
    • Affects Version/s: 3.0.0, 3.0.1
    • Fix Version/s: 3.0.2
    • Labels:
      None
    • Template:
    • Development Team:
      Gulfstream
    • Release:
      Q2 2020

      Description

      Overview

      While running the module locally using the fat jar, I noticed that there wasn't any output from the logger... Upon investigation I found that:

      src/main/resources/log4j.properties still exists and is being copied into the fat jar.
      the log4j2.properties file lives under src/test/resources and is NOT being copied into the fat jar.

      There are also a few places in the pom which expilcitly point to the old log4j.properties.

      This should be cleaned up.

      • remove the old log4j.properties
      • copy/move the log4j2.properties from src/test/resources to src/main/resources so it's included in the fat jar.
      • set the log4j2.configurationFile system property instead of log4j.configurationFile in the surefire plugin configuration in pom.xml

      Acceptance Criteria

      • log4j2 is used by unit tests
      • log4j2.properties is included in the fat jar
      • references to log4j.properties are cleaned up.

        TestRail: Results

          Attachments

            Issue Links

              Activity

                People

                Assignee:
                energ1zr Dmytro Popov
                Reporter:
                cmcnally Craig McNally
                Tester Assignee:
                Craig McNally Craig McNally
                Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                  Dates

                  Created:
                  Updated:
                  Resolved:

                    TestRail: Runs

                      TestRail: Cases