Details
-
Bug
-
Status: Closed (View Workflow)
-
P2
-
Resolution: Done
-
1.2.1, 1.2.2, 1.3.0
-
CP: sprint 91
-
5
-
Core: Platform
Description
Remediation
Upgrade org.pac4j:pac4j-saml to version 3.8.3 or later. For example:
<dependency> <groupId>org.pac4j</groupId> <artifactId>pac4j-saml</artifactId> <version>[3.8.3,)</version> </dependency>
Always verify the validity and compatibility of suggestions with your codebase.
Details CVE-2019-10755
low severity
*Vulnerable versions:* < 3.8.3
*Patched version:* 3.8.3
The SAML identifier generated within SAML2Utils.java was found to make use of the apache commons-lang3 RandomStringUtils class which makes them predictable due to RandomStringUtils PRNG's algorithm not being cryptographically strong.
https://snyk.io/vuln/SNYK-JAVA-ORGPAC4J-467407 says: "This issue only affects the 3.X release of pac4j-saml." This is wrong.
pac4j-saml 2.0.0 (used by mod-login-saml) is also affected:
- https://github.com/pac4j/pac4j/blob/pac4j-2.0.0/pac4j-saml/src/main/java/org/pac4j/saml/metadata/SAML2MetadataGenerator.java#L159
- https://github.com/pac4j/pac4j/blob/pac4j-2.0.0/pac4j-saml/src/main/java/org/pac4j/saml/sso/impl/SAML2AuthnRequestBuilder.java#L128
pac4j-saml 1.9.9 is also affected:
- https://github.com/pac4j/pac4j/blob/pac4j-1.9.9/pac4j-saml/src/main/java/org/pac4j/saml/metadata/SAML2MetadataGenerator.java#L159
- https://github.com/pac4j/pac4j/blob/pac4j-1.9.9/pac4j-saml/src/main/java/org/pac4j/saml/sso/impl/SAML2AuthnRequestBuilder.java#L128
Details CVE-2019-17195
http://www.pac4j.org/docs/release-notes.html say:
pac4j v3.8.3: Upgrade the nimbus-jose-jwt library to version 7.9 because of CVE-2019-17195
TestRail: Results
Attachments
Issue Links
- blocks
-
MODLOGSAML-65 Create mod-login-saml security release
-
- Closed
-
- is duplicated by
-
MODLOGSAML-52 Fix org.pac4j:pac4j-saml security vulnerabilities
-
- Closed
-
-
MODLOGSAML-55 org.pac4j:pac4j-saml vulnerability found in pom.xml on Nov 6, 2019
-
- Closed
-
- relates to
-
MODLOGSAML-67 Upgrade to pac4j-saml 4.1.0, Cryptacular 1.2.4 (CVE-2020-7226)
-
- Closed
-