Uploaded image for project: 'mod-login'
  1. mod-login
  2. MODLOGIN-171

Logs ERROR when using default config values

    XMLWordPrintable

Details

    • Bug
    • Status: Closed (View Workflow)
    • TBD
    • Resolution: Done
    • 4.3.1, 7.5.0
    • 7.6.0
    • None
    • CP: sprint 127
    • 1
    • Core: Platform
    • GBV

    Description

      Steps to Reproduce:

      1. Don't use (delete) the mod-login configuration options that reside in mod-configuration:
        1. login.fail.attempts
        2. login.fail.timeout
        3. login.fail.to.warn.attempts
      2. Log into some FOLIO environment as any user
      3. The login succeeds.

      Expected Results:

      No error message in the logs.

      Actual Results:

      These errors in the log

      ERROR LoginAttemptsHelper  No config found by code login.fail.attempts
      ERROR LoginAttemptsHelper  No config found by code login.fail.timeout
      ERROR LoginAttemptsHelper  No config found by code login.fail.to.warn.attempts 

      Information:

      When the config option is missing the default values are used. This is documented in the README: https://github.com/folio-org/mod-login/blob/v7.5.0/README.md#module-properties-to-set-up-at-mod-configuration

      https://github.com/folio-org/mod-login/blob/v7.5.0/src/main/java/org/folio/util/LoginAttemptsHelper.java#L166-L169 **

      TODO:

      Suppress any ERROR and WARN messages in the log if the missing config option results in using the default value. An INFO message is fine.

      TestRail: Results

        Attachments

          Issue Links

            Activity

              People

                adam Adam Dickmeiss
                julianladisch Julian Ladisch
                Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved:

                  TestRail: Runs

                    TestRail: Cases