Uploaded image for project: 'mod-kb-ebsco-java'
  1. mod-kb-ebsco-java
  2. MODKBEKBJ-426

Embargo time units are not properly converted

    XMLWordPrintable

    Details

    • Template:
    • Sprint:
      eHoldings Sprint 86
    • Story Points:
      1
    • Development Team:
      Spitfire

      Description

      Embargo time unit converter do not ignore case of letters. This leads to failures during conversion of values that don't start from upper case letter.

      For instance unit = "years" is not converted because "Years" is expected as a value. Sample RM API response that contains unit in lower case:

      GET https://sandbox.ebsco.io/rm/rmaccounts/apidvgvmt/vendors/18/packages/1357/titles/50974

      {
          "titleId": 88680,
          "titleName": "Nature Reviews Cancer",
          "publisherName": "Nature Publishing Group",
          "identifiersList": [
              {
                  "id": "109103",
                  "source": "ResourceIdentifier",
                  "subtype": 0,
                  "type": 4
              },
              {
                  "id": "1474-175X",
                  "source": "ResourceIdentifier",
                  "subtype": 1,
                  "type": 0
              },
              {
                  "id": "1474-1768",
                  "source": "ResourceIdentifier",
                  "subtype": 2,
                  "type": 0
              },
              {
                  "id": "48623853",
                  "source": "ResourceIdentifier",
                  "subtype": 0,
                  "type": 2
              },
              {
                  "id": "617057807",
                  "source": "ResourceIdentifier",
                  "subtype": 0,
                  "type": 3
              },
              {
                  "id": "617058042",
                  "source": "ResourceIdentifier",
                  "subtype": 0,
                  "type": 3
              },
              {
                  "id": "88680",
                  "source": "AtoZ",
                  "subtype": 0,
                  "type": 9
              },
              {
                  "id": "LKC",
                  "source": "MFS",
                  "subtype": 0,
                  "type": 8
              }
          ],
          "subjectsList": [
              {
                  "type": "TLI",
                  "subject": "Oncology"
              }
          ],
          "isTitleCustom": false,
          "pubType": "Journal",
          "customerResourcesList": [
              {
                  "titleId": 88680,
                  "packageId": 1357,
                  "packageName": "Academic OneFile",
                  "packageType": "Complete",
                  "proxy": {
                      "id": "Proxy-ID-123",
                      "inherited": true
                  },
                  "isPackageCustom": false,
                  "vendorId": 18,
                  "vendorName": "Gale | Cengage",
                  "locationId": 1640680,
                  "isSelected": false,
                  "isTokenNeeded": false,
                  "visibilityData": {
                      "isHidden": false,
                      "reason": ""
                  },
                  "managedCoverageList": [
                      {
                          "beginCoverage": "2001-10-01",
                          "endCoverage": ""
                      }
                  ],
                  "customCoverageList": [],
                  "coverageStatement": null,
                  "managedEmbargoPeriod": {
                      "embargoUnit": "years",
                      "embargoValue": 1
                  },
                  "customEmbargoPeriod": {
                      "embargoUnit": null,
                      "embargoValue": 0
                  },
                  "url": "http://link.galegroup.com/apps/pub/2IHV/AONE?u=[[galesiteid]]",
                  "userDefinedField1": null,
                  "userDefinedField2": null,
                  "userDefinedField3": null,
                  "userDefinedField4": null,
                  "userDefinedField5": null,
                  "selectedBy": "Unknown"
              }
          ],
          "description": "Covers all areas within the broad fields of cancer research, integrating cancer biology with new approaches to treatment, diagnosis and prevention.",
          "edition": null,
          "isPeerReviewed": true,
          "contributorsList": []
      }
      

      Requirements

      • embargo period converter should ignore letter case of time units

        TestRail: Results

          Attachments

            Issue Links

              Activity

                People

                Assignee:
                dmtkachenko Dmytro Tkachenko
                Reporter:
                dmtkachenko Dmytro Tkachenko
                Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                  Dates

                  Created:
                  Updated:
                  Resolved:

                    TestRail: Runs

                      TestRail: Cases