Uploaded image for project: 'mod-inventory-storage'
  1. mod-inventory-storage
  2. MODINVSTOR-619

source property in holdingsrecordssource.json is missing type property

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: P3
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: 20.0.0
    • Labels:
      None
    • Template:
      Standard Bug Write-Up Format
    • Sprint:
      Core: F - Sprint 103, Prokopovych - Sprint 104
    • Story Points:
      2
    • Development Team:
      Prokopovych

      Description

      holdingsrecordssource.json is defined as:

      PS C:\Temp\FOLIO\mod-inventory-storage\ramls> cat holdingsrecordssource.json
      {
        "$schema": "http://json-schema.org/draft-04/schema#",
        "description": "A holdings records source",
        "type": "object",
        "properties": {
          "id": {
            "type": "string",
            "description": "The unique ID of the holdings records source; UUID",
            "$ref": "uuid.json"
          },
          "name": {
            "type": "string",
            "description": "Name of the holdings records source"
          },
          "source": {
            "enum": [
              "folio",
              "local"
            ],
            "description": "The holdings records source"
          },
          "metadata": {
            "type": "object",
            "$ref": "raml-util/schemas/metadata.schema",
            "readonly": true
          }
        },
        "required": [
          "name"
        ]
      }
      

      Can you add a type property of string to the source property like so?

          "source": {
            "type": "string",
            "enum": [
              "folio",
              "local"
            ],
            "description": "The holdings records source"
          },
      

      enum properties in the other JSON schemas all seem to define a type for the field as well. I'm using the type in a code generation tool that I created.

      I wonder why these fields aren't just in the holdings table, but, that's another issue.

        TestRail: Results

          Attachments

            Issue Links

              Activity

                People

                Assignee:
                felkerk Kyle Felker
                Reporter:
                jemiller Jon Miller
                Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                  Dates

                  Created:
                  Updated:
                  Resolved:

                    TestRail: Runs

                      TestRail: Cases