Uploaded image for project: 'mod-inventory-storage'
  1. mod-inventory-storage
  2. MODINVSTOR-489

InstanceStorageTest fails (hit count related)

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: TBD
    • Resolution: Won't Do
    • Affects Version/s: None
    • Fix Version/s: None
    • Template:
    • Development Team:
      Core: Platform

      Description

      As of today, mod-inventory-storage (master) uses 29.4.0.

      If I point to 29.5.0-SNAPSHOT, then tests start to fail.

      mvn -B -Dtest=InstanceStorageTest test
      
        InstanceStorageTest.canGetWithOptimizedSql:668 
      Expected: is <999999999>
           but: was <10>
        InstanceStorageTest.canSearchByTitleAndBarcodeWithMissingHoldingsAndItemsAndStillGetInstances:1252 
      Expected: is <2>
           but: was <12720>
        InstanceStorageTest.canSortAscending:1330->canSort:1016->matchInstanceTitles:1005 totalRecords
      Expected: is <5>
           but: was <39200>
        InstanceStorageTest.canSortDescending:1336->canSort:1016->matchInstanceTitles:1005 totalRecords
      Expected: is <5>
           but: was <24892>
        InstanceStorageTest.testCrossTableQueries:1517 
      Expected: is <24941>
           but: was <3>
      

      Running git bisect gives:

      d79e914d4397fa099e3b79a36e756471077d684f is the first bad commit
      commit d79e914d4397fa099e3b79a36e756471077d684f
      Author: MikhailFokanov <Mikhail_Fokanov@epam.com>
      Date:   Wed Apr 15 20:18:24 2020 +0300
      
          RMB-591 Count_estimate_optimized implemented
      
       .../main/java/org/folio/rest/persist/PgUtil.java   | 54 ++++++++++++++--------
       .../org/folio/rest/persist/PostgresClient.java     |  2 +-
       .../templates/db_scripts/general_functions.ftl     | 22 ++++++++-
       3 files changed, 58 insertions(+), 20 deletions(-)
      bisect run success
      

        TestRail: Results

          Attachments

            Issue Links

              Activity

                People

                Assignee:
                adam Adam Dickmeiss
                Reporter:
                adam Adam Dickmeiss
                Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                  Dates

                  Created:
                  Updated:
                  Resolved:

                    TestRail: Runs

                      TestRail: Cases