Details
-
Bug
-
Status: Closed (View Workflow)
-
P2
-
Resolution: Done
-
None
-
None
-
None
-
Sif Sprint 158
-
Sif
-
Orchid (R1 2023)
-
Implementation coding issue
Description
The BoundWithAPI.isValid method returns a Future<Boolean>. If the validation fails the Future succeeds with a false boolean.
However, Futures are designed to return failures as a failed Future.
Therefore Future<Void> should be returned so that the caller of isValid can better handle the error.
The org.folio.rest.exceptions.ValidationException can be used. This also fixes the error response that currently doesn't comply with the RAML error response spec:
{ "map" : { "holdings" : { "list" : [ "Holdings record 5dad1351-1a77-447b-b5fe-a14c2ed280e2 not found." ], "empty" : false } }, "empty" : false }
TestRail: Results
Attachments
Issue Links
- continues
-
MODINVSTOR-1022 Bound-with. New PUT API where a single item ID and a list of holdings IDs can be created
-
- Closed
-
- defines
-
UXPROD-3922 R1 2023 | Sif Enhancements/Bugfixes/NFR/tech debt
-
- Closed
-