Details
-
Bug
-
Status: Closed (View Workflow)
-
P3
-
Resolution: Done
-
None
-
None
-
ACQ Sprint 118
-
1
-
Thunderjet
-
R2 2021 Bugfix
Description
Overview:
src/main/java/org/folio/services/invoice/BaseInvoiceService.java#recalculateInvoiceTotals is doing the opposite of what it is supposed to do, and also has wrong Javadoc.
According to the Javadoc, it is supposed to return "true if adjustments total, sub total or grand total value is different to original one". What it does is that it returns true if the adjustment total is equal to the original one (without looking at the other totals).
This has an effect in src/main/java/org/folio/invoices/events/handlers/InvoiceSummary.java : the invoice record is updated when it is not needed, and not updated when it is needed.
Possible Resolution:
The result of recalculateInvoiceTotals should be reversed, and the Javadoc updated in recalculateInvoiceTotals and recalculateTotals to reflect the fact that the other totals are ignored.
TestRail: Results
Attachments
Issue Links
- blocks
-
MODINVOICE-268 MODINVOICE (mod-invoice) R2 Bugfix release
-
- Closed
-
- defines
-
UXPROD-2630 Thunderjet - R2 Enhancements/Bugfixes
-
- Closed
-
- relates to
-
MODINVOICE-233 Integration test check-invoice-and-invoice-lines-deletion-restrictions fails randomly
-
- Closed
-