Uploaded image for project: 'mod-gobi'
  1. mod-gobi
  2. MODGOBI-52

No workflow_status mapping for ListedElectronicMonograph

    XMLWordPrintable

Details

    • Bug
    • Status: Closed (View Workflow)
    • P3
    • Resolution: Done
    • None
    • 1.3.0
    • None
    • ACQ Sprint 58
    • 1
    • EBSCO - FSE

    Description

      Overview:
      The default mappings should set workflow_status to "Open", but this mapping is absent from the default ListedElectronicMonograph mappings.

      Note that the resulting order has workflow_status = "Pending"...

      curl http://folio-testing-backend01.aws.indexdata.com:9130/gobi/orders -H "X-Okapi-Token: $TOKEN" -w '\n' -XPOST -H "Content-Type: application/xml" --data-binary @src/test/resources/GOBIIntegrationServiceResourceImpl/po_listed_electronic_monograph.xml
      <?xml version="1.0" encoding="UTF-8" standalone="yes"?><Response><PoLineNumber>10019-1</PoLineNumber></Response>
      
      curl "http://folio-testing-backend01.aws.indexdata.com:9130/orders/composite-orders?query=po_number==10019" -H "X-Okapi-Token: $TOKEN" -w '\n' -XGET
      {
        "purchase_orders" : [ {
          "id" : "02e25f8c-8da5-480d-a961-5f3757241179",
          "approved" : true,
          "manual_po" : false,
          "notes" : [ ],
          "po_number" : "10019",
          "order_type" : "One-Time",
          "total_items" : 1,
          "vendor" : "a187d39e-2760-4691-b689-0c33f0f7bc25",
          "workflow_status" : "Pending",
          "metadata" : {
            "createdDate" : "2019-02-22T20:41:38.824+0000",
            "createdByUserId" : "0758d6d8-3e0f-52bc-aa98-2eb9cb9fd7cd",
            "updatedDate" : "2019-02-22T20:41:38.824+0000",
            "updatedByUserId" : "0758d6d8-3e0f-52bc-aa98-2eb9cb9fd7cd"
          }
        } ],
        "total_records" : 1
      }
      
      curl "http://folio-testing-backend01.aws.indexdata.com:9130/orders/composite-orders/02e25f8c-8da5-480d-a961-5f3757241179" -H "X-Okapi-Token: $TOKEN" -w '\n' -XGET
      {
        "id" : "02e25f8c-8da5-480d-a961-5f3757241179",
        "approved" : true,
        "manual_po" : false,
        "notes" : [ ],
        "po_number" : "10019",
        "order_type" : "One-Time",
        "total_items" : 1,
        "vendor" : "a187d39e-2760-4691-b689-0c33f0f7bc25",
        "workflow_status" : "Pending",
        "compositePoLines" : [ {
          "id" : "4f87491b-f8a9-4c31-9a2d-e555ccc83be4",
          "acquisition_method" : "Purchase At Vendor System",
          "alerts" : [ ],
          "claims" : [ {
            "id" : "0c43ea71-7db0-49ea-ae27-2c3be0ce2ce2",
            "claimed" : true,
            "grace" : 45,
            "po_line_id" : "4f87491b-f8a9-4c31-9a2d-e555ccc83be4"
          } ],
          "collection" : false,
          "contributors" : [ {
            "contributor" : "GALE, CENGAGE LEARNING"
          } ],
          "cost" : {
            "id" : "1df53245-d3ed-4cb6-9c51-fcae0532e344",
            "list_price" : 29.99,
            "currency" : "USD",
            "quantity_electronic" : 1,
            "po_line_estimated_price" : 29.99,
            "po_line_id" : "4f87491b-f8a9-4c31-9a2d-e555ccc83be4"
          },
          "details" : {
            "id" : "6215a489-5ab6-46f1-aa2d-6e44c45cdd56",
            "receiving_note" : "Let Bob know",
            "product_ids" : [ {
              "product_id" : "9781410352224",
              "product_id_type" : "ISBN"
            } ],
            "material_types" : [ "1a54b431-2e4f-452d-9cae-9cee66c9a892" ],
            "po_line_id" : "4f87491b-f8a9-4c31-9a2d-e555ccc83be4"
          },
          "eresource" : {
            "id" : "fcf39eab-b695-438c-9c7d-dc1cccc22854",
            "activated" : false,
            "activation_due" : 3,
            "create_inventory" : false,
            "trial" : false,
            "expected_activation" : "2019-02-25T20:41:38.775+0000",
            "po_line_id" : "4f87491b-f8a9-4c31-9a2d-e555ccc83be4"
          },
          "fund_distribution" : [ {
            "id" : "8675dbbf-92f1-44de-964b-9f790122bc6d",
            "code" : "e2a5bdc9-ce30-4df8-bcf2-f92a8398d528",
            "percentage" : 100.0,
            "po_line_id" : "4f87491b-f8a9-4c31-9a2d-e555ccc83be4"
          } ],
          "locations" : [ {
            "id" : "f2f68442-51d9-4ee7-938c-3ce44db15d59",
            "location_id" : "758258bc-ecc1-41b8-abca-f7b610822ffd",
            "po_line_id" : "4f87491b-f8a9-4c31-9a2d-e555ccc83be4",
            "quantity" : 1,
            "quantity_electronic" : 1
          } ],
          "order_format" : "Electronic Resource",
          "owner" : "8910",
          "payment_status" : "Awaiting Payment",
          "physical" : {
            "id" : "3feb5d43-efcb-4f4a-8435-157a9df5fbe6",
            "volumes" : [ ],
            "po_line_id" : "4f87491b-f8a9-4c31-9a2d-e555ccc83be4"
          },
          "po_line_number" : "10019-1",
          "publisher" : "GALE, CENGAGE LEARNING",
          "purchase_order_id" : "02e25f8c-8da5-480d-a961-5f3757241179",
          "receipt_status" : "Receipt Not Required",
          "reporting_codes" : [ ],
          "requester" : "Bob Barker",
          "source" : {
            "id" : "2584eac7-c1b7-4bb4-af36-84e1b5710a71",
            "code" : "mod-gobi",
            "description" : "An order placed from GOBI Interface"
          },
          "tags" : [ ],
          "title" : "STUDY GUIDE FOR PHILIP K. DICK'S \"MARTIAN TIME-SLIP\";.",
          "vendor_detail" : {
            "id" : "f665eecc-b420-4f71-aab9-b83779787446",
            "instructions" : "N/A",
            "note_from_vendor" : "EBS3U",
            "ref_number" : "99974828472",
            "ref_number_type" : "Supplier's unique order line reference number",
            "vendor_account" : "891025",
            "po_line_id" : "4f87491b-f8a9-4c31-9a2d-e555ccc83be4"
          },
          "metadata" : {
            "createdDate" : "2019-02-22T20:41:38.922+0000",
            "createdByUserId" : "0758d6d8-3e0f-52bc-aa98-2eb9cb9fd7cd",
            "updatedDate" : "2019-02-22T20:41:38.922+0000",
            "updatedByUserId" : "0758d6d8-3e0f-52bc-aa98-2eb9cb9fd7cd"
          }
        } ],
        "metadata" : {
          "createdDate" : "2019-02-22T20:41:38.824+0000",
          "createdByUserId" : "0758d6d8-3e0f-52bc-aa98-2eb9cb9fd7cd",
          "updatedDate" : "2019-02-22T20:41:38.824+0000",
          "updatedByUserId" : "0758d6d8-3e0f-52bc-aa98-2eb9cb9fd7cd"
        }
      }
      

      and I was able to verify this looking at the mapping json files:

      grep -i flow src/main/resources/*.json
      src/main/resources/ListedElectronicSerial.json:          "field": "WORKFLOW_STATUS",
      src/main/resources/ListedPrintMonograph.json:          "field": "WORKFLOW_STATUS",
      src/main/resources/ListedPrintSerial.json:          "field": "WORKFLOW_STATUS",
      src/main/resources/mapping.json:        "PO_LINE_WORKFLOW_STATUS",
      src/main/resources/mapping.json:        "WORKFLOW_STATUS"
      src/main/resources/UnlistedPrintMonograph.json:          "field": "WORKFLOW_STATUS",
      src/main/resources/UnlistedPrintSerial.json:          "field": "WORKFLOW_STATUS",
      

      Note the absence of src/main/resources/ListedElectronicMonograph.json

      Acceptance Criteria:

      • WORKFLOW_STATUS is mapped to the default value of "Open" for ListedElectronicMonograph orders.

      TestRail: Results

        Attachments

          Issue Links

            Activity

              People

                cmcnally Craig McNally
                cmcnally Craig McNally
                Craig McNally Craig McNally
                Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved:

                  TestRail: Runs

                    TestRail: Cases