Uploaded image for project: 'mod-finance-storage'
  1. mod-finance-storage
  2. MODFISTO-304

Lock budgets to update totals

    XMLWordPrintable

Details

    • Story
    • Status: Closed (View Workflow)
    • P3
    • Resolution: Done
    • None
    • 8.2.0
    • None
    • ACQ Sprint 141
    • 2
    • Thunderjet
    • Morning Glory (R2 2022)
    • TBD

    Description

      Purpose/Overview:
      Currently budget updates can conflict when 2 transactions are applied in parallel for the same budget. We can prevent this issue by locking the budgets with Postgres when getting budgets/applying changes/updating them.

      Requirements/Scope:
      Use a Postgres lock in EncumbranceService$updateBudgetsTotals, PaymentCreditService$updateBudgetsTotals, and PendingPaymentService.

      Approach:

      • Use a Postgres transaction. There is already one created in AllOrNothingTransactionService, so we probably don't need to do anything.
      • Use SELECT ... FOR UPDATE when getting the budgets to update (add getBudgetsForUpdate() to budgetService).
      • Make sure the transaction is ended at the end, or rolled back if an error occurs (this is already done in AllOrNothingTransactionService).
      • Use the parallel-update-order-lines-different-orders test from MODFISTO-260.

      Acceptance criteria:

      • parallel-update-order-lines-different-orders never fails anymore.
      • Unit tests and integration tests (finance, orders, invoices, cross-module) pass.

      TestRail: Results

        Attachments

          Issue Links

            defines

            New Feature - New feature requests UXPROD-3663 Part 1 - Finance - Implementing Optimistic Locking

            • P3 - low priority level, item will be considered for inclusion in the next dev cycle
            • Closed

            New Feature - New feature requests UXPROD-3666 Improve support for parallel processing

            • TBD - To be determined
            • In Refinement
            has to be done after

            Story - Created by Jira Software - do not edit or delete. Issue type for a user story. MODFISTO-303 Enable optimistic locking

            • P3 - low priority level, item will be considered for inclusion in the next dev cycle
            • Closed
            has to be done before

            Story - Created by Jira Software - do not edit or delete. Issue type for a user story. MODFISTO-314 POC: fix the transaction API

            • TBD - To be determined
            • Closed

            Story - Created by Jira Software - do not edit or delete. Issue type for a user story. STSMACOM-668 ControlledVocab - optimistic locking

            • P3 - low priority level, item will be considered for inclusion in the next dev cycle
            • Closed

            Story - Created by Jira Software - do not edit or delete. Issue type for a user story. UIF-379 Finance optimistic locking

            • P3 - low priority level, item will be considered for inclusion in the next dev cycle
            • Closed

            Story - Created by Jira Software - do not edit or delete. Issue type for a user story. UISACQCOMP-104 Create common component OptimisticLockingBanner

            • P3 - low priority level, item will be considered for inclusion in the next dev cycle
            • Closed
            relates to

            Bug - A problem which impairs or prevents the functions of the product. MODFISTO-259 Releasing 2 transactions at the same time can fail to update budgets

            • P3 - low priority level, item will be considered for inclusion in the next dev cycle
            • Blocked

            Task - A task that needs to be done. MODFISTO-297 Spike: Proof of concept to support parallel requests

            • TBD - To be determined
            • Closed

            Activity

              People

                Andrei_Makaranka Andrei Makaranka
                damieng Damien Guillaume
                Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved:

                  TestRail: Runs

                    TestRail: Cases