Details
-
Bug
-
Status: Closed (View Workflow)
-
P1
-
Resolution: Done
-
None
-
ACQ Sprint 137
-
1
-
Thunderjet
-
Lotus (R1 2022) Bug Fix
-
-
Implementation coding issue
Description
Overview:
When an error occurs in createTransaction or updateTransaction, the temporary transactions are currently not cleaned up. Because the same id is currently used to process transactions for orders or invoices again, and because processAllOrNothing compares the number of temporary transactions to the number of expected transactions, this causes the processing of failed temporary transactions with some new ones, and the subsequent error "All expected transactions already processed".
Since the calling mods will give up on the whole set of transactions if a single one fails, we should remove all the related temporary transactions in case of failure, for any case of failure (including validation).
MODFISTO-268 will resolve this issue, but the resolution is too complex to be included in a hot fix. On the other hand, cleaning up the temp transactions is easy and can be included in a hot fix.
Steps to Reproduce:
See related stories.
Expected Results:
User can try again if an operation (such as invoice approval) fails.
Actual Results:
The operation keeps failing with the message "All expected transactions already processed".
Additional Information:
In AllOrNothingTransactionService, deleteTempTransactions should be called if there is an error within createTransaction, updateTransaction or processAllOrNothing.
Interested parties:
TestRail: Results
Attachments
Issue Links
- blocks
-
MODFISTO-296 mod-finance-storage: R1 Lotus Bugfix release
-
- Closed
-
- defines
-
UXPROD-3666 Improve support for parallel processing
-
- In Refinement
-
- is cloned by
-
MODFISTO-301 R3 Kiwi (2021) Hotfix #3 - Error All expected transactions already processed
-
- Closed
-
- relates to
-
MODFISTO-281 Invoice Transaction not created
-
- Closed
-
-
MODINVOICE-363 Can not pay invoice that references the same POL and 2 different invoice lines
-
- Closed
-
-
MODINVOICE-395 R3 Kiwi (2021) Hotfix #3 - Can not pay invoice that references the same POL and 2 different invoice lines
-
- Closed
-
-
MODFISTO-268 Option to provide a summary id parameter in the transaction API
-
- Blocked
-
-
MODINVOICE-387 Insufficient fund validation to approve invoice
-
- Closed
-
-
MODINVOICE-396 Kiwi (R3 2021) Hot Fix #3 - Insufficient fund validation to approve invoice
-
- Closed
-
-
MODINVOICE-398 Lotus HF#1 - Insufficient fund validation to approve invoice
-
- Closed
-