Uploaded image for project: 'mod-finance-storage'
  1. mod-finance-storage
  2. MODFISTO-268

Option to provide a summary id parameter in the transaction API

    XMLWordPrintable

Details

    • Story
    • Status: Blocked (View Workflow)
    • P3
    • Resolution: Unresolved
    • None
    • None
    • None

    Description

      Purpose/Overview:

      To resolve MODFISTO-260, batch transactions cannot be linked with the order id / invoice id anymore. So we need to pass an additional parameter, the summary id, for POST/PUT transaction calls.

      Also, since transaction summaries are not using order or invoice ids as the key anymore, they are unique and should not need to be modified, so we can deprecate PUT for transaction summaries (there might be a need for that for troubleshooting which we will have to check, but this can be done later).

      Requirements/Scope:

      1. Add optional transactionSummaryId query parameter for the following:
        POST /finance-storage/transactions
        PUT /finance-storage/transactions/{id}
      2. The following should be deprecated:
        PUT /finance-storage/order-transaction-summaries/{id}
        PUT /finance-storage/invoice-transaction-summaries/{id}

      Approach:

      Update ramls/transaction.raml and ramls/transaction-summary.raml.

      Use the new summary id instead of the order id or invoice id as the key for transaction summaries.

      Acceptance criteria:

      • Match requirements
      • Update unit tests

      Update:
      I had to go beyond this scope in order to use the new summary id, and implemented most of the needed changes in MODFISTO for MODFISTO-260. Given the scope change I postponed the PUT summary deprecation.

      TestRail: Results

        Attachments

          Issue Links

            Activity

              People

                Unassigned Unassigned
                damieng Damien Guillaume
                Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                  Created:
                  Updated:

                  TestRail: Runs

                    TestRail: Cases