During a version upgrade of the module, I noticed migration scripts being executed that cross the module database boundary. For example, the pending_payment_cross_module.ftl contains joins with the database schema for mod-invoice-storage, and update_encumbrances_order_status.ftl joins with the database schema for mod-orders-storage. Those were the two I ran across, I didn't attempt a full audit.
This fundamentally breaks the FOLIO storage model and the contract between modules. Among the issues it could cause:
- Storage schemas for mod-finance-storage and other modules may not be co-located in the same database
- Alternative API implementations will not be able to interoperate with this module