Uploaded image for project: 'mod-finance-storage'
  1. mod-finance-storage
  2. MODFISTO-134

Can invoice_transaction_summaries and order_transaction_summaries tables be eliminated? Otherwise, add CRUD methods

    XMLWordPrintable

Details

    • Thunderjet

    Description

      I'm wondering if invoice_transaction_summaries and order_transaction_summaries are actually needed?

      For example, order_transaction_summary.json contains only a numTransactions property. Can you just query the transactions live to get the count? I guess maybe the fact that it says "expected" means that the transactions don't yet exist?

      {
        "$schema": "http://json-schema.org/draft-04/schema#",
        "description": "Order transactions summary",
        "type": "object",
        "extends" : {
          "$ref" : "../../common/schemas/entity.json"
        },
        "properties": {
          "id": {
            "description": "UUID of this summary",
            "$ref": "../../common/schemas/uuid.json"
          },
          "numTransactions": {
            "description": "Total number of transactions (encumbrances) expected for this order. Negative value indicates that all transactions have been processed",
            "type": "integer"
          }
        },
        "additionalProperties": false,
        "required": [
          "id",
          "numTransactions"
        ]
      }
      

      If the answer is no, can you add the normal CRUD APIs for managing these tables?

      If you look at https://s3.amazonaws.com/foliodocs/api/mod-finance/p/transaction-summary.html you can see the API only support POST and PUT, but not GET or DELETE.

      You need both of those when migrating data. When working on migrations, you need the ability to clear the tables.

      TestRail: Results

        Attachments

          Issue Links

            Activity

              People

                Andrei_Makaranka Andrei Makaranka
                jemiller Jon Miller
                Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                  Created:
                  Updated:

                  TestRail: Runs

                    TestRail: Cases