Details
-
Story
-
Status: Closed (View Workflow)
-
TBD
-
Resolution: Won't Do
-
None
-
None
-
None
-
Thunderjet
-
Poppy (R2 2023)
Description
Purpose/Overview:
To resolve MODFISTO-260, batch transactions cannot be linked with the order id / invoice id anymore. So we need to pass an additional parameter, the summary id, for all POST/PUT transaction calls.
Also, since transaction summaries are not using order or invoice ids as the key anymore, they are unique and should not need to be modified, so we can deprecate PUT for transaction summaries (there might be a need for that for troubleshooting which we will have to check, but this can be done later).
Requirements/Scope:
- Add optional transactionSummaryId query parameter for the following by updating:
POST /finance/encumbrances
PUT /finance/encumbrances/{id}
POST /finance/payments
POST /finance/pending-payments
PUT /finance/pending-payments/{id} - Pass it to mod-finance-storage in the same way if it is defined for:
POST /finance-storage/transactions
PUT /finance-storage/transactions/{id} - The following should be deprecated:
PUT /finance/order-transaction-summaries/{id}
PUT /finance/invoice-transaction-summaries/{id}
Approach:
The transaction schema can be updated at ramls/transaction.raml and ramls/transaction-summary.
For the above transaction API calls, the query parameters should be validated and passed to mod-finance-storage.
Acceptance criteria:
- Requirements should be met.
- Unit tests will have to be updated.
- mod-orders and cross-module integration tests should be checked.
TestRail: Results
Attachments
Issue Links
- defines
-
MODFISTO-260 Transaction summaries are not designed to be used in parallel
-
- Closed
-
-
UXPROD-3434 Implement new finance transaction model to protect against parallel processing
-
- Closed
-
- has to be done before
-
MODINVOICE-307 Update transaction summary API calls
-
- Closed
-
-
MODORDERS-581 Update transaction summary API calls
-
- Closed
-
- has to be finished together with
-
MODFISTO-268 Option to provide a summary id parameter in the transaction API
-
- Closed
-