"manual-block-templates.collection.get" permission is required when attempting to add a manual patron block to any user through the users UI

Please see https://issues.folio.org/browse/CIRC-1117 for more info.

Following TCs was executed to indicate a problem:

Precondition:

Logged in as user with all permissions

Steps:

1. Go to Settings > Users > Permission sets

2. Click New to add a new permission set.

    Expected Result: You are sent to the Create permission set view

3. Fill in the fields Title ("Circulation") and Description

4. Add permissions that will let the user

• Access the following apps:
  • Check in
  • Check out
  • Users
  • Requests
  • Inventory
• Perform the following actions:
  • Check in: all actions
  • Check out: all actions
  • Users: search, filter and view; create and edit users;
  • but NOT add/edit/remove the following to/from users: Permissions, Proxies, Service points
  • Requests: all actions
  • Inventory: search, filter and view records
• Administer the following settings
  • None

5. Click Create permission set

    Expected Result: A new permission set is created. You are sent back to the three pane Settings view. The new permission set is listed among existing permission sets.

6. Go to Users and create a new user, and assign it permission set Circulation.
Assign a Service point and Service point preference to this user, to enable circulation activities.

7. Log in as the user to which you assigned the permission set Circulation

    Expected Result: You are logged into FOLIO. Looking at the app menu, you see the following apps, and no others:

• Check in
• Check out
• Users
• Requests
• Inventory

8.

9. (Failed) Perform various tasks (see test cases for apps [...]) to verify that the user is able to

• Access the following apps:
  • Check in
  • Check out
  • Users
  • Requests
  • Inventory
• Perform the following actions:
  • Check in: all actions
  • Check out: all actions
  • Users: search, filter and view; create and edit users; but NOT add/edit/remove the following to/from users: Permissions, Proxies, Service points
  • Requests: all actions
  • Inventory: search, filter and view records
• Administer the following settings
  • None

 
    Expected Result
    The user is able to

• Access the following apps:
  • Check in
  • Check out
  • Users
  • Requests
  • Inventory
• Perform the following actions:
  • Check in: all actions
  • Check out: all actions
  • Users: search, filter and view; create and edit users;
  • but NOT add/edit/remove the following to/from users: Permissions, Proxies, Service points
  • Requests: all actions
  • Inventory: search, filter and view records
• Administer the following settings
  • None

    Actual Result
    1. This portion passed. User is able to see and access all the apps listed.
    2.a. Several portions of the add user crashed but uncertain if this is a user app bug or permission issue (think user app bug?) Crashed when selecting: Eissorten, Zweigstelle fields,
Display note as a pop-up and Major. Set a Block and received ERROR: Access requires permission: manual-block-templates.collection.get

    2.b. Looking at a User account with Fine/Fee, click on the link and ERROR (Access requires permissions: refund.collection.get 

Then windows opens and I see Open fees/fines for that user. I can then click on Closed, All and Export with no issues. And I can create a new fine/fee. When I click away to Check In app I get a message that Something went wrong with a button to Return to Check in landing page and end up at Welcome screen. Back in User screen looking at Fines/Fees, click on any of the links and I get the access error for each of them. Click on OK, Error window closes and the screen opens and I can work in there.
    2.c Check out works fine.
    2.d. Check in works fine unless there is a fine/fee then the ERROR: Access requires permission: lost-items-fees-policies.collection.get. Click on OK in error window and I can
proceed without issue. Item returned and in transit to shelving location.
    2.e. Requests work fine.

10. (Failed) For reproducibility and future reference, add a comment to the test result specifying which permissions you included in the permission set.
     Actual Result
Check in: All permissions
Check out: All permissions
Inventory: View instance records being suppressed for staff
Inventory: View instances, holdings, and items
Requests: All permissions
Users: Can create new user
Users: Can create, edit and remove fees/fines
Users: Can create, edit and remove patron blocks
Users: Can edit user profile
Users: Can view permissions assigned to users
Users: Can view proxies assigned to users
Users: Can view service points assigned to users
Users: Can view user profile
Users: Create/reset password
Users: User loans anonymize
Users: User loans change due date
Users: User loans claim returned
Users: User loans declare lost
Users: User loans mark claimed returned missing
Users: User loans renew
Users: User loans renew through override
Users: User loans view
Users: User loans view, edit, renew (all)
Users: View requests

For full circulation functionality may need to add fine/fee permissions as well.

An investigation was carried out by felkerk:

When attempting to add a manual patron block to any user through the users UI, a modal pops up indicating a permission called "manual-block-templates.collection.get" is needed. I'm having a harder time pinpointing where this error is coming from, the url that's throwing it (https://core-functional-okapi.ci.folio.org/manual-block-templates?limit=100) seems to be directed at okapi rather than mod-circulation. Manual blocks are not implemented by mod-circulation, rather by mod-feesfines. If this endpoint is requested directly from the front-end it is likely that a front-end module is missing that permission. 

Please note that these problems are only seen when you try to perform the action with a user with the specific permissions set in the description. If you test with the admin user, you won’t see the error, likely because the permission is included in some other permission set the admin user has