Uploaded image for project: 'mod-data-export-worker'
  1. mod-data-export-worker
  2. MODEXPW-26

Release 1.1.3, fixing startup failure (application.yml)



    • Story
    • Status: Closed (View Workflow)
    • P1
    • Resolution: Done
    • None
    • None
    • None
    • Scout
    • GBV


      Release v1.1.2 is completely broken and fails when starting.

      How to reproduce:

      a) Using git

      git checkout v1.1.2
      mvn clean install
      java -jar target/mod-data-export-worker-1.1.2.jar

      b) Using docker

      docker run folioorg/mod-data-export-worker:1.1.2 

      a) and b) fail with this error:

      java.lang.IllegalStateException: Failed to load property source from 'jar:file:/home/me/mod-data-export-worker/target/mod-data-export-worker-1.1.2.jar!/BOOT-INF/classes!/application.yml' (classpath:/application.yml)
              at org.springframework.boot.context.config.ConfigFileApplicationListener$Loader.load(ConfigFileApplicationListener.java:553) ~[spring-boot-2.3.4.RELEASE.jar!/:2.3.4.RELEASE]
      Caused by: org.yaml.snakeyaml.scanner.ScannerException: mapping values are not allowed here
       in 'reader', line 48, column 16:
                  enabled: false
                         ^        at org.yaml.snakeyaml.scanner.ScannerImpl.fetchValue(ScannerImpl.java:870) ~[snakeyaml-1.26.jar!/:?]

      mod-data-export-worker:1.1.2 is used at master of platform-complete and fails the platform-complete deployment used for https://folio-demo.gbv.de : https://github.com/folio-org/platform-complete/blob/master/okapi-install.json#L223

      Fix: Release v1.1.3 from mod-data-export-worker master branch because the master branch already contains a fix.

      Additional information:

      The v1.1.2 release has been made from the commit 656f4dc on Jul 5 06:07:46. This was used to create the docker file.

      The fix was added with commit 3308c73 on Jul 5 09:58:07.

      commit 3308c73203bb7f6ee229026f0244e695e7f6ce83 (HEAD -> master, origin/master, origin/HEAD)
      Merge: 15d8637 7cfbf64
      Author: Roman Leshchenko <76975537+Roman-Leshchenko@users.noreply.github.com>
      Date:   Mon Jul 5 09:58:07 2021 +0300
          Merge pull request #95 from folio-org/fix-envs
          fix build
      commit 7cfbf6469d47b12dbdbc31a485dc2b0410be5c34 (origin/fix-envs)
      Author: Roman Leshchenko <roman_leshchenko@epam.com>
      Date:   Mon Jul 5 09:49:35 2021 +0300
          fix build
      commit 15d8637cf8482d5709513ffd5ff0211f1abfa539 
      Merge: 8f47e5e 42ac910
      Author: Roman Leshchenko <76975537+Roman-Leshchenko@users.noreply.github.com>
      Date:   Mon Jul 5 06:15:54 2021 +0300
          Merge pull request #94 from folio-org/b1.1
      commit 42ac910e493856c9c671dff0ee3e70755aadcb8c
      Author: Roman Leshchenko <roman_leshchenko@epam.com>
      Date:   Mon Jul 5 06:07:47 2021 +0300
          [maven-release-plugin] prepare for next development iteration
      commit 656f4dc4243a41cd382b943212dbf301daaadfed (tag: v1.1.2)
      Author: Roman Leshchenko <roman_leshchenko@epam.com>
      Date:   Mon Jul 5 06:07:46 2021 +0300
          [maven-release-plugin] prepare release v1.1.2 

      The v1.1.2 tag was changed to point to commit 80b400a on Jul 5 10:29:49.

      git pull doesn't update a tag.

      The Docker image for v1.1.2 was overwritten with the change.

      However, Docker images are cached, all deployment scripts assume that a Docker image for one version doesn't change, in general there is no reliable way to overwrite an existing version of a Docker image.

      A new version is required.

      TestRail: Results




              julianladisch Julian Ladisch
              julianladisch Julian Ladisch
              0 Vote for this issue
              2 Start watching this issue



                TestRail: Runs

                  TestRail: Cases