Uploaded image for project: 'mod-authtoken'
  1. mod-authtoken
  2. MODAT-107

Filter returns X-Okapi-Module-Tokens on error

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: TBD
    • Resolution: Done
    • Affects Version/s: 2.9.0
    • Fix Version/s: 2.9.1
    • Labels:
    • Template:
    • Sprint:
      CP: sprint 125
    • Story Points:
      2
    • Development Team:
      Core: Platform

      Description

      mod-authtoken returns headers in case of 403-type of errors, such as X-Okapi-Module-Tokens. This tricked Okapi to save them (OKAPI-1037).. But in general, headers like these should not be returned in case of errors.

      It can be spotted in code sections easily - as if the mod-authtoken deliberately wants to return that header always.

      https://github.com/folio-org/mod-authtoken/blob/ee0ada57495b2613191cb2cc4880c32fcef577bc/src/main/java/org/folio/auth/authtokenmodule/MainVerticle.java#L706

      https://github.com/folio-org/mod-authtoken/blob/ee0ada57495b2613191cb2cc4880c32fcef577bc/src/main/java/org/folio/auth/authtokenmodule/MainVerticle.java#L724

      https://github.com/folio-org/mod-authtoken/blob/ee0ada57495b2613191cb2cc4880c32fcef577bc/src/main/java/org/folio/auth/authtokenmodule/MainVerticle.java#L755

        TestRail: Results

          Attachments

            Issue Links

            relates to

            Bug - A problem which impairs or prevents the functions of the product. OKAPI-1037 Missing permission check when token cache and pre/post filter

            • P2 - normal priority level, must be included in the current development cycle
            • Closed

            Bug - A problem which impairs or prevents the functions of the product. MODAT-38 Missing module token when calling /token as a filter

            • P3 - low priority level, item will be considered for inclusion in the next dev cycle
            • Closed

              Activity

                People

                Assignee:
                adam Adam Dickmeiss
                Reporter:
                adam Adam Dickmeiss
                Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                  Dates

                  Created:
                  Updated:
                  Resolved:

                    TestRail: Runs

                      TestRail: Cases