Uploaded image for project: 'mod-data-export'
  1. mod-data-export
  2. MDEXP-189

Export fails with NPE when dataOfPublication is null

    XMLWordPrintable

Details

    • Bug
    • Status: Closed (View Workflow)
    • P3
    • Resolution: Done
    • None
    • 2.0.0
    • None
    • Standard Bug Write-Up Format
    • Concorde - Sprint 90
    • 1
    • Concorde

    Description

      Overview
      If dataOfPublication is null then the code throws NPE and the logs have no information.
      This was observed on snapshot environment with the follwing record

      "@context" : "http://folio-snapshot-okapi.aws.indexdata.com/inventory/instances/context",
          "id" : "00f10ab9-d845-4334-92d2-ff55862bf4f9",
          "hrid" : "inst000000000002",
          "source" : "FOLIO",
          "title" : "American Bar Association journal.",
          "indexTitle" : "American Bar Association journal.",
          "alternativeTitles" : [ ],
          "editions" : [ ],
          "series" : [ ],
          "identifiers" : [ {
            "identifierTypeId" : "c858e4f2-2b6b-4385-842b-60732ee14abb",
            "value" : "15017355"
          }, {
            "identifierTypeId" : "7e591197-f335-4afb-bc6d-a6d76ca3bace",
            "value" : "1964851"
          }, {
            "identifierTypeId" : "7e591197-f335-4afb-bc6d-a6d76ca3bace",
            "value" : "236213576"
          }, {
            "identifierTypeId" : "913300b2-03ed-469a-8179-c1092c991227",
            "value" : "0002-7596"
          }, {
            "identifierTypeId" : "913300b2-03ed-469a-8179-c1092c991227",
            "value" : "0002-7596"
          }, {
            "identifierTypeId" : "7e591197-f335-4afb-bc6d-a6d76ca3bace",
            "value" : "(ICU)BID9651294"
          }, {
            "identifierTypeId" : "7e591197-f335-4afb-bc6d-a6d76ca3bace",
            "value" : "(OCoLC)1479565"
          }, {
            "identifierTypeId" : "7e591197-f335-4afb-bc6d-a6d76ca3bace",
            "value" : "(OCoLC)1964851"
          }, {
            "identifierTypeId" : "7e591197-f335-4afb-bc6d-a6d76ca3bace",
            "value" : "(OCoLC)236213576"
          }, {
            "identifierTypeId" : "7e591197-f335-4afb-bc6d-a6d76ca3bace",
            "value" : "2363771"
          } ],
          "contributors" : [ {
            "contributorNameTypeId" : "d376e36c-b759-4fed-8502-7130d1eeff39",
            "name" : "American Bar Association",
            "contributorTypeId" : "6e09d47d-95e2-4d8a-831b-f777b8ef6d81",
            "contributorTypeText" : "",
            "primary" : null
          }, {
            "contributorNameTypeId" : "d376e36c-b759-4fed-8502-7130d1eeff39",
            "name" : "American Bar Association. Journal",
            "contributorTypeId" : "06b2cbd8-66bf-4956-9d90-97c9776365a4",
            "contributorTypeText" : "",
            "primary" : null
          } ],
          "subjects" : [ "Law--United States--Periodicals", "Advocatuur.--gtt", "Droit--Périodiques", "LAW--unbist", "LAWYERS--unbist", "UNITED STATES--unbist", "Law.--fast", "United States.--fast" ],
          "classifications" : [ {
            "classificationNumber" : "K1 .M385",
            "classificationTypeId" : "ce176ace-a53e-4b4d-aa89-725ed7b2edac"
          }, {
            "classificationNumber" : "KB1 .A437",
            "classificationTypeId" : "ce176ace-a53e-4b4d-aa89-725ed7b2edac"
          }, {
            "classificationNumber" : "347.05 A512",
            "classificationTypeId" : "42471af9-7d25-4f3a-bf78-60d29dcf463b"
          } ],
          "publication" : [ {
            "publisher" : "American Bar Association",
            "place" : "Chicago, Ill.",
            "dateOfPublication" : null,
            "role" : null
          } ],
          "publicationFrequency" : [ "Monthly, 1921-83", "Quarterly, 1915-20" ],
          "publicationRange" : [ "Began with vol. 1, no. 1 (Jan. 1915); ceased with v. 69, [no.12] (Dec. 1983)" ],
          "electronicAccess" : [ ],
          "instanceTypeId" : "6312d172-f0cf-40f6-b27d-9fa8feaf332f",
          "instanceFormatIds" : [ "volume nc rdacarrier" ],
          "physicalDescriptions" : [ "69 v. : ill. ; 23-30 cm." ],
          "languages" : [ "eng" ],
          "notes" : [ ],
          "discoverySuppress" : false,
          "statisticalCodeIds" : [ ],
          "metadata" : {
            "createdDate" : "2020-06-03T03:35:41.412+0000",
            "createdByUserId" : null,
            "updatedDate" : "2020-06-03T03:35:41.412+0000",
            "updatedByUserId" : null
          },
          "tags" : {
            "tagList" : [ ]
          },
          "natureOfContentTermIds" : [ ],
          "links" : {
            "self" : "http://folio-snapshot-okapi.aws.indexdata.com/inventory/instances/00f10ab9-d845-4334-92d2-ff55862bf4f9"
          }
        }
      

      Cause: There is no null check for datesOfPublication Field

      Also observed the issue if the createdDate is empty:

      "metadata" : {
            "createdDate" : ""
      }
      

      Acceptance Criteria

      • Null check added, and handle gracefully
      • More debug logging to be added to be able to identify the associated record. There were no logs whatsoever in the logs.

      TestRail: Results

        Attachments

          Issue Links

            Activity

              People

                Andrii Andrii Novytskyi
                KVupp Kruthi Vuppala
                Magda Zacharska Magda Zacharska
                Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved:

                  TestRail: Runs

                    TestRail: Cases