Uploaded image for project: 'liquibase-util'
  1. liquibase-util
  2. LIQUTIL-17

Pass exceptions, don't catch and swallow them

    XMLWordPrintable

Details

    • CP: sprint 134
    • 0
    • Core: Platform
    • Lotus R1 2022
    • Implementation coding issue

    Description

      LiquibaseUtil catches exceptions, logs them, but swallows (ignores) them so that the caller assumes that the method succeeded successfully:

      https://github.com/folio-org/folio-liquibase-util/blob/v1.3.0/src/main/java/org/folio/liquibase/LiquibaseUtil.java#L46

      https://github.com/folio-org/folio-liquibase-util/blob/v1.3.0/src/main/java/org/folio/liquibase/LiquibaseUtil.java#L64

      See these reports of silent liquibase fails:

      RMB-895
      MODSOURCE-380
      MODSOURCE-381

      LiquibaseUtil should pass on all exceptions. Checked exceptions should be wrapped as unchecked exceptions to avoid a breaking change of the method declaration.

      TestRail: Results

        Attachments

          Issue Links

            blocks

            Bug - A problem which impairs or prevents the functions of the product. RMB-895 mod-srs: Upgrade (when liquibase exception) fails silently

            • P3 - low priority level, item will be considered for inclusion in the next dev cycle
            • Closed
            defines

            New Feature - New feature requests UXPROD-3262 NFR: Data Import R1 2022 Lotus Technical, NFR, & Misc work

            • P2 - normal priority level, must be included in the current development cycle
            • Closed
            relates to

            Bug - A problem which impairs or prevents the functions of the product. MODSOURCE-380 Exception when upgrading from Iris to Juniper (Liquibase script)

            • P1 - highest priority item, drop everything else before this is resolved, reserved for critical bugfixes
            • Closed

            Bug - A problem which impairs or prevents the functions of the product. MODSOURCE-381 Source Record Storage upgrade fails with error

            • P1 - highest priority item, drop everything else before this is resolved, reserved for critical bugfixes
            • Closed

            Activity

              People

                julianladisch Julian Ladisch
                julianladisch Julian Ladisch
                Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved:

                  TestRail: Runs

                    TestRail: Cases