Details
-
Story
-
Status: Closed (View Workflow)
-
P1
-
Resolution: Done
-
None
-
-
ACQ Sprint 155
-
0
-
Thunderjet
-
Morning Glory (R2 2022) Hot Fix #1
-
Related dependency upgrade
Description
has been copied and pasted six times:
- https://github.com/folio-org/mod-finance/blob/v4.5.2/src/main/java/org/folio/completablefuture/FolioVertxCompletableFuture.java
- https://github.com/folio-org/mod-gobi/blob/v2.4.3/src/main/java/org/folio/completablefuture/FolioVertxCompletableFuture.java
- https://github.com/folio-org/mod-invoice/blob/v5.4.1/src/main/java/org/folio/completablefuture/FolioVertxCompletableFuture.java
- https://github.com/folio-org/mod-invoice-storage/blob/v5.4.0/src/main/java/org/folio/completablefuture/FolioVertxCompletableFuture.java
- https://github.com/folio-org/mod-orders/blob/v12.4.3/src/main/java/org/folio/completablefuture/FolioVertxCompletableFuture.java
- https://github.com/folio-org/mod-orders-storage/blob/v13.3.3/src/main/java/org/folio/completablefuture/FolioVertxCompletableFuture.java
This is a maintenance nightmare because
- the code is duplicated multiple times
- there are no unit tests (unit tests https://github.com/cescoffier/vertx-completable-future/tree/vertx-completable-future-0.1.2/src/test/java/me/escoffier/vertx/completablefuture haven't been copied)
How to fix
Fork https://github.com/cescoffier/vertx-completable-future to https://github.com/folio-org
Put in changes needed for FOLIO.
Make a FOLIO release of it.
Let FOLIO modules use the FOLIO release.
TestRail: Results
Attachments
Issue Links
- relates to
-
FOLIO-3608 Replace FolioVertxCompletableFuture usage
-
- Open
-
-
FOLREL-547
Morning Glory (2022 R2) - Remove vertx-completable-future
-
- Closed
-