Uploaded image for project: 'FOLIO'
  1. FOLIO
  2. FOLIO-3432

Update NodeJS to Active LTS (v16) in GitHub Actions images

    XMLWordPrintable

Details

    • DevOps Sprint 139, DevOps Sprint 140, DevOps Sprint 141, DevOps Sprint 142
    • FOLIO DevOps
    • TBD

    Description

      Summary: Use NodeJS's Active LTS (v16 as of February 2022) in GitHub Actions CI images, by setting NODEJS_VERSION: '16' in /.github/actions/build-npm* and changing related values accordingly for NodeJS 16/NPM 8 compatibility. There are four changes in total in the .github/workflows files:

      1. replace 
        NODEJS_VERSION: '12'

        with

        NODEJS_VERSION: '16'
      2. below FOLIO_NPM_REGISTRY, in build-npm-release.yml add 
        FOLIO_NPM_REGISTRY_AUTH: '//repository.folio.org/repository/npm-folio/'

        and in build-npm.yml add

        FOLIO_NPM_REGISTRY_AUTH: '//repository.folio.org/repository/npm-folioci/'
      3. replace 
        npm config set _auth $NODE_AUTH_TOKEN

        with

        npm config set $FOLIO_NPM_REGISTRY_AUTH:_auth $NODE_AUTH_TOKEN
      4. in multiple locations, replace 
        uses: actions/setup-node@v2

        with

        uses: actions/setup-node@v3

      This is also a good time to remove engines.node from package.json because that is a statement of production compatibility and in production this is not a node app. Although we leverage node in development to run lint, tests, compile translations, etc., node is not a production dependency.

      Details: While investigating some recent UI test failures in CI, we discovered the build-npm.yml files used by most UI repos pin the NodeJS version to v12 (e.g. from ui-requests), a release that is nearing EOL. We’d like to stick to the Active LTS (v16 at present), which I think will happen automatically if we unset the node-version, or if we accept the default version. I don't have strong feelings about the "right" approach; I am sympathetic to avoiding defaults in order to directly control the env as much as possible, but also to the fact that we have many UI apps and issuing 60+ "bump Node's Active LTS version" PRs every year is no fun.

      Additional relevant links originally provided by julianladisch:

      TestRail: Results

        Attachments

          Issue Links

            blocks

            Task - A task that needs to be done. FOLIO-3452 Roll out Github Actions to remaining ui-* and stripes-* repos using the developed Python script

            • TBD - To be determined
            • Closed

            Bug - A problem which impairs or prevents the functions of the product. FOLIO-3510 UI builds fail in CI during translation compilation

            • P3 - low priority level, item will be considered for inclusion in the next dev cycle
            • Closed
            is cloned by

            Task - A task that needs to be done. FOLIO-3434 Update NodeJS to Active LTS (v16) in Jenkins images

            • TBD - To be determined
            • Closed
            relates to

            New Feature - New feature requests FOLIO-3433 provide Dockerfile-ish access to GitHub Actions CI images

            • P3 - low priority level, item will be considered for inclusion in the next dev cycle
            • Open

            Bug - A problem which impairs or prevents the functions of the product. FOLIO-3510 UI builds fail in CI during translation compilation

            • P3 - low priority level, item will be considered for inclusion in the next dev cycle
            • Closed

            Story - Created by Jira Software - do not edit or delete. Issue type for a user story. FOLIO-3511 Verify node v16 build with a Jenkins-based UI module repo

            • P3 - low priority level, item will be considered for inclusion in the next dev cycle
            • Closed

            Task - A task that needs to be done. ERM-2957 update NodeJS to v16 in GitHub Actions

            • TBD - To be determined
            • Closed

            Task - A task that needs to be done. ESCONF-22 update NodeJS to v16 in GitHub Actions

            • TBD - To be determined
            • Closed

            Task - A task that needs to be done. FOLIO-3324 Pin to node 14 for release builds

            • TBD - To be determined
            • Closed

            Bug - A problem which impairs or prevents the functions of the product. FOLIO-3509 npm publish fails in CI boxes after Node 16 upgrade

            • TBD - To be determined
            • Closed

            Task - A task that needs to be done. STCLI-208 update NodeJS to v16 in GitHub Actions

            • TBD - To be determined
            • Closed

            Task - A task that needs to be done. STCOM-996 update NodeJS to v16 in GitHub Actions

            • TBD - To be determined
            • Closed

            Task - A task that needs to be done. STCON-134 update NodeJS to v16 in GitHub Actions

            • TBD - To be determined
            • Closed

            Task - A task that needs to be done. STCOR-623 update NodeJS to v16 in GitHub Actions

            • TBD - To be determined
            • Closed

            Task - A task that needs to be done. STFORM-23 update NodeJS to v16 in GitHub Actions

            • TBD - To be determined
            • Closed

            Task - A task that needs to be done. STRIPES-802 update NodeJS to v16 in GitHub Actions

            • TBD - To be determined
            • Closed

            Task - A task that needs to be done. STRIPESFF-16 update NodeJS to v16 in GitHub Actions

            • TBD - To be determined
            • Closed

            Task - A task that needs to be done. STSMACOM-664 update NodeJS to v16 in GitHub Actions

            • TBD - To be determined
            • Closed

            Task - A task that needs to be done. STUTL-24 update NodeJS to v16 in GitHub Actions

            • TBD - To be determined
            • Closed

            Task - A task that needs to be done. UIAC-51 update NodeJS to v16 in GitHub Actions

            • TBD - To be determined
            • Closed

            Task - A task that needs to be done. UIBULKED-94 update NodeJS to v16 in GitHub Actions

            • TBD - To be determined
            • Closed

            Task - A task that needs to be done. UICAL-202 update NodeJS to v16 in GitHub Actions

            • TBD - To be determined
            • Closed

            Task - A task that needs to be done. UICHKIN-338 update NodeJS to v16 in GitHub Actions

            • TBD - To be determined
            • Closed

            Task - A task that needs to be done. UICHKOUT-782 update NodeJS to v16 in GitHub Actions

            • TBD - To be determined
            • Closed

            Task - A task that needs to be done. UICIRC-815 update NodeJS to v16 in GitHub Actions

            • TBD - To be determined
            • Closed

            Task - A task that needs to be done. UICIRCLOG-99 update NodeJS to v16 in GitHub Actions

            • TBD - To be determined
            • Closed

            Task - A task that needs to be done. UICR-156 update NodeJS to v16 in GitHub Actions

            • TBD - To be determined
            • Closed

            Task - A task that needs to be done. UID-115 update NodeJS to v16 in GitHub Actions

            • TBD - To be determined
            • Closed

            Task - A task that needs to be done. UIDATIMP-1179 update NodeJS to v16 in GitHub Actions

            • TBD - To be determined
            • Closed

            Task - A task that needs to be done. UIDEXP-278 update NodeJS to v16 in GitHub Actions

            • TBD - To be determined
            • Closed

            Task - A task that needs to be done. UIEH-1283 update NodeJS to v16 in GitHub Actions

            • TBD - To be determined
            • Closed

            Task - A task that needs to be done. UIEUS-294 update NodeJS to v16 in GitHub Actions

            • TBD - To be determined
            • Closed

            Task - A task that needs to be done. UIEXPMGR-45 update NodeJS to v16 in GitHub Actions

            • TBD - To be determined
            • Closed

            Task - A task that needs to be done. UIF-382 update NodeJS to v16 in GitHub Actions

            • TBD - To be determined
            • Closed

            Task - A task that needs to be done. UIIN-2049 update NodeJS to v16 in GitHub Actions

            • TBD - To be determined
            • Closed

            Task - A task that needs to be done. UIINREACH-174 update NodeJS to v16 in GitHub Actions

            • TBD - To be determined
            • Closed

            Task - A task that needs to be done. UILDP-55 update NodeJS to v16 in GitHub Actions

            • TBD - To be determined
            • Closed

            Task - A task that needs to be done. UIMARCAUTH-149 update NodeJS to v16 in GitHub Actions

            • TBD - To be determined
            • Closed

            Task - A task that needs to be done. UIMPROF-71 update NodeJS to v16 in GitHub Actions

            • TBD - To be determined
            • Closed

            Task - A task that needs to be done. UINOTES-126 update NodeJS to v16 in GitHub Actions

            • TBD - To be determined
            • Closed

            Task - A task that needs to be done. UINV-409 update NodeJS to v16 in GitHub Actions

            • TBD - To be determined
            • Closed

            Task - A task that needs to be done. UIOA-120 update NodeJS to v16 in GitHub Actions

            • TBD - To be determined
            • Closed

            Task - A task that needs to be done. UIOAIPMH-54 update NodeJS to v16 in GitHub Actions

            • TBD - To be determined
            • Closed

            Task - A task that needs to be done. UIOR-974 update NodeJS to v16 in GitHub Actions

            • TBD - To be determined
            • Closed

            Task - A task that needs to be done. UIORGS-319 update NodeJS to v16 in GitHub Actions

            • TBD - To be determined
            • Closed

            Task - A task that needs to be done. UIPBEX-37 update NodeJS to v16 in GitHub Actions

            • TBD - To be determined
            • Closed

            Task - A task that needs to be done. UIPCIR-37 update NodeJS to v16 in GitHub Actions

            • TBD - To be determined
            • Closed

            Task - A task that needs to be done. UIPER-95 update NodeJS to v16 in GitHub Actions

            • TBD - To be determined
            • Closed

            Task - A task that needs to be done. UIPFCONT-25 update NodeJS to v16 in GitHub Actions

            • TBD - To be determined
            • Closed

            Task - A task that needs to be done. UIPFF-7 update NodeJS to v16 in GitHub Actions

            • TBD - To be determined
            • Closed

            Task - A task that needs to be done. UIPFI-103 update NodeJS to v16 in GitHub Actions

            • TBD - To be determined
            • Closed

            Task - A task that needs to be done. UIPFIMP-49 update NodeJS to v16 in GitHub Actions

            • TBD - To be determined
            • Closed

            Task - A task that needs to be done. UIPFINT-29 update NodeJS to v16 in GitHub Actions

            • TBD - To be determined
            • Closed

            Task - A task that needs to be done. UIPFO-29 update NodeJS to v16 in GitHub Actions

            • TBD - To be determined
            • Closed

            Task - A task that needs to be done. UIPFPAT-44 update NodeJS to v16 in GitHub Actions

            • TBD - To be determined
            • Closed

            Task - A task that needs to be done. UIPFPOL-45 update NodeJS to v16 in GitHub Actions

            • TBD - To be determined
            • Closed

            Task - A task that needs to be done. UIPFU-52 update NodeJS to v16 in GitHub Actions

            • TBD - To be determined
            • Closed

            Task - A task that needs to be done. UIPFU-67 update NodeJS to v16 in GitHub Actions

            • TBD - To be determined
            • Closed

            Task - A task that needs to be done. UIPFUDP-21 update NodeJS to v16 in GitHub Actions

            • TBD - To be determined
            • Closed

            Task - A task that needs to be done. UIQM-241 update NodeJS to v16 in GitHub Actions

            • TBD - To be determined
            • Closed

            Task - A task that needs to be done. UIREC-240 update NodeJS to v16 in GitHub Actions

            • TBD - To be determined
            • Closed

            Task - A task that needs to be done. UIREQ-780 update NodeJS to v16 in GitHub Actions

            • TBD - To be determined
            • Closed

            Task - A task that needs to be done. UIRS-78 update NodeJS to v16 in GitHub Actions

            • TBD - To be determined
            • Closed

            Task - A task that needs to be done. UISE-153 update NodeJS to v16 in GitHub Actions

            • TBD - To be determined
            • Closed

            Task - A task that needs to be done. UISP-34 update NodeJS to v16 in GitHub Actions

            • TBD - To be determined
            • Closed

            Task - A task that needs to be done. UITAG-55 update NodeJS to v16 in GitHub Actions

            • TBD - To be determined
            • Closed

            Task - A task that needs to be done. UITEN-215 update NodeJS to v16 in GitHub Actions

            • TBD - To be determined
            • Open

            Task - A task that needs to be done. UITEN-252 update NodeJS to v16 in GitHub Actions

            • TBD - To be determined
            • Closed

            Task - A task that needs to be done. UIU-2607 update NodeJS to v16 in GitHub Actions

            • TBD - To be determined
            • Closed

            Activity

              People

                ankitasen Ankita Sen
                zburke Zak_Burke
                Votes:
                0 Vote for this issue
                Watchers:
                7 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved:

                  TestRail: Runs

                    TestRail: Cases