Uploaded image for project: 'ERM Platform'
  1. ERM Platform
  2. ERM-995

When harvesting from GOKb the GOKbOAI Adapter can process TIPPs from a package that aren't required

    XMLWordPrintable

    Details

    • Template:
    • Sprint:
      ERM Sprint 93, ERM Sprint 94
    • Development Team:
      ERM

      Description

      Packages from GOKb are not created/updated in the internal KB if they don't meet certain conditions

      Specifically the follow code conditions apply :

        PackageSchema json_package_description = gokbToERM(record, trustedSourceTI)
            if ( json_package_description.header.status == 'deleted' ) {
              // ToDo: Decide what to do about deleted records
            }
            else {
              if (editStatus.toLowerCase() != 'approved') {
                log.info("Ignoring Package '${package_name}' because editStatus=='${editStatus}' (required: 'approved')")
              } else if (listStatus.toLowerCase() != 'checked') {
                log.info("Ignoring Package '${package_name}' because listStatus=='${listStatus}' (required: 'checked')")
              } else {
                cache.onPackageChange(source_name, json_package_description)
              }
            }
      

      However, by the time the code reaches this point, the full package has been processed including processing all the TIPPs in the package. This results in unnecessary work and also can make the log files noising (because potentially each TIPP can result in a log entry, and TIPPs in packages that have not yet been approved in GOKb are more likely to have issues that will lead to log entries)

      Propose that initially only the header is processed, and the TIPPs are processed only if it is decided that the package will be ingested to the local KB

        TestRail: Results

          Attachments

            Activity

              People

              Assignee:
              Unassigned Unassigned
              Reporter:
              ostephens Owen Stephens
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  TestRail: Runs

                    TestRail: Cases