Details
-
Bug
-
Status: Closed (View Workflow)
-
P2
-
Resolution: Done
-
ERM Sprint 144, ERM Sprint 145
-
Bienenvolk
-
Morning Glory (R2 2022) Bug Fix
-
Legitimate regression
Description
Overview:
Seeing repeated errors of the type "StaleObjectStateException" on MG bugfest in mod-agreements
In some cases the error is not just generated in the logs but also included in the API response
Steps to Reproduce:
- Log into https://bugfest-mg.int.aws.folio.org/
- Open agreement https://bugfest-mg.int.aws.folio.org/erm/agreements/861b0312-1172-4d4c-93fd-97cfdc6f7262
- See agreement doesn't display correctly and in console see response includes a stack trace
Additional Information:
- Discussion in Slack channel: https://folio-project.slack.com/archives/CAYCU07SN/p1658397120027459
- Bugfest logs from 2022-07-20_15-17-03 to 2022-07-22_10-02-03 available from https://www.dropbox.com/sh/lrmyxr4p7fxuzx0/AAA8alFFpV3ozWegRq6FHQp5a?dl=0
In these logs 26 objects lead to the error occurring:
com.k_int.web.toolkit.settings.AppSetting#2c9180867860f3940178657ed9fc0003 org.olf.erm.Entitlement#01927280-bf5a-4961-946e-cda8dbada0ed org.olf.erm.Entitlement#06d8ab89-b493-4201-b402-83b6faaeb3b4 org.olf.erm.Entitlement#08e1ef6e-439f-49e0-8e52-9764a92914c5 org.olf.erm.Entitlement#11a9b43a-6adf-4ef6-ba3c-4d9e17c0c594 org.olf.erm.Entitlement#259e26f3-a376-4035-8644-a66ced181851 org.olf.erm.Entitlement#426a5821-bdef-4514-84b5-5b665edc7cd5 org.olf.erm.Entitlement#44daadb3-f362-4e9c-ade4-ebdf4388cc54 org.olf.erm.Entitlement#44ea2f36-45f4-4e71-b730-a025091b0701 org.olf.erm.Entitlement#4bcad56e-6554-4f46-ae48-2a82619e9bfd org.olf.erm.Entitlement#68fc39d7-1ce9-4981-b470-5111bdfb8349 org.olf.erm.Entitlement#74c31eff-ad02-4961-ad52-92159a0c364c org.olf.erm.Entitlement#77eb8cee-c2a8-4077-a87c-d71e58921ee7 org.olf.erm.Entitlement#79a641b2-b1db-4877-9fff-984207cb8eca org.olf.erm.Entitlement#94f6b9cc-e783-4192-afad-61042e9327a0 org.olf.erm.Entitlement#9b69279d-fd35-4214-b596-fdde5c663b2d org.olf.erm.Entitlement#abdefe59-6997-497c-8a94-250923c3ff90 org.olf.erm.Entitlement#c440bc0d-4929-4098-8f43-1caad8bb6438 org.olf.erm.Entitlement#d05cce2e-574b-4a9e-8f4b-59d9c6fe29e9 org.olf.erm.Entitlement#d18e9637-8851-42fa-bed3-d53ae9e7c8a6 org.olf.erm.Entitlement#e54b1778-17ee-4fc0-86c1-c477bf106170 org.olf.erm.Entitlement#e688083a-ce94-432a-a0ba-9cfaba73105e org.olf.erm.Entitlement#e8e9d229-4d27-4be9-948b-b0edc73f22b0 org.olf.erm.Entitlement#e9df15f9-838f-4935-8302-721136bf11ba org.olf.erm.Entitlement#f04df74a-c0f3-4e44-b437-6569141584f9 org.olf.erm.Entitlement#fad8e662-b891-4f14-880f-1cedf49bf9e5
All these Entitlements are type = external with an EKB resource linked. The Entitlements all appear with the error >1 times in the log with org.olf.erm.Entitlement#d05cce2e-574b-4a9e-8f4b-59d9c6fe29e9 appearing 111 times - but it seems likely that this is probably due to it being an Entitlement linked to "2019 Trial Agreement" which happens to be the first result in the list of agreements on the opening search and filter screen - so probably just repeated a lot because people keep viewing that same agreement.
The error for com.k_int.web.toolkit.settings.AppSetting#2c9180867860f3940178657ed9fc0003 appears only once
Logs also contain many errors of the type "org.hibernate.exception.GenericJDBCException: Unable to release JDBC Connection" which suggests the DB connections aren't behaving as expected. Possibly hikari is being forced to constantly create new connections to account for the ones being snapped out from under it.