Uploaded image for project: 'ERM Platform'
  1. ERM Platform
  2. ERM-2203

Only retrieve license terms if there is at least one license linked to agreement

    XMLWordPrintable

Details

    • ERM Sprint 142
    • Bienenvolk
    • Morning Glory (R2 2022)
    • TBD

    Description

      Overview:
      A GET to `/licenses/custprops` is triggered on viewing an agreement even if that agreement is not linked to a license.

      Steps to Reproduce:

      1. Create an agreement with minimal data, no license
      2. Open browser dev console
      3. View agreement

      Expected Results:
      Not GET to license/custprops endpoint

      Actual Results:
      A GET is made to license/custprops endpoint

      Additional Information:
      Relevant code https://github.com/folio-org/ui-agreements/blob/dfd5ec38111746047f058dafaf0aa4e084f6009b/src/components/views/Agreement/Agreement.js#L72

      Ethan comment on slack: "we need to add some queryParams to only fire that when we have >1 licence linked"

      TestRail: Results

        Attachments

          Issue Links

            Activity

              People

                ostephens Owen Stephens
                ostephens Owen Stephens
                Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved:

                  TestRail: Runs

                    TestRail: Cases