Details
-
Task
-
Status: Closed (View Workflow)
-
TBD
-
Resolution: Done
-
-
ERM Sprint 116
-
Bienenvolk
Description
StringTemplateBulkSpec integration test in mod-agreements currently takes a long time to run.
See https://folio-project.slack.com/archives/CAYCU07SN/p1622636845086800
In particular the "Load Packages" testcase takes 815s
<testsuite name="org.olf.StringTemplateBulkSpec" tests="7" skipped="0" failures="0" errors="0" timestamp="2021-06-02T12:08:54" hostname="alcubierre" time="830.462"> <properties/> <testcase name="Pre purge tenant" classname="org.olf.StringTemplateBulkSpec" time="0.032"/> <testcase name="Ensure test tenant" classname="org.olf.StringTemplateBulkSpec" time="4.567"/> <testcase name="Load Packages" classname="org.olf.StringTemplateBulkSpec" time="815.153"/> <testcase name="Create StringTemplates" classname="org.olf.StringTemplateBulkSpec" time="0.266"/> <testcase name="Templating triggers without errors" classname="org.olf.StringTemplateBulkSpec" time="3.178"/> <testcase name="Check initial templating is complete" classname="org.olf.StringTemplateBulkSpec" time="0.498"/>
Dev task breakdown
It seems we can cut this spec down considerably and still have it functionally testing what we need here.
Try removing the elsevier package and compare timings:
https://github.com/folio-org/mod-agreements/blob/master/service/src/integration-test/groovy/org/olf/StringTemplateBulkSpec.groovy#L50
Alternatively if that isn't performing templating on "enough" resources, instead we could cut down the packages within the files themselves.