Details
-
Bug
-
Status: Closed (View Workflow)
-
TBD
-
Resolution: Done
-
-
ERM Sprint 124
-
Bienenvolk
-
GBV, University of Leipzig
Description
These translations keys have strings that contain the placeholder {type}:
"emptyAccordion.coreDocuments": "No core documents for this {type}", "emptyAccordion.terms": "No terms for this {type}", "emptyAccordion.supplementaryDocuments": "No supplementary documents for this {type}",
This is their usage:
https://github.com/folio-org/ui-licenses/blob/v5.0.0/src/components/viewSections/CoreDocs.js#L63 :
<FormattedMessage id="ui-licenses.emptyAccordion.coreDocuments" values={{ type: type.toLowerCase() }} />
https://github.com/folio-org/ui-licenses/blob/v5.0.0/src/components/viewSections/Terms.js#L27 :
<FormattedMessage id="ui-licenses.emptyAccordion.terms" values={{ type: type.toLowerCase() }} />
<FormattedMessage id="ui-licenses.emptyAccordion.supplementaryDocuments" values={{ type: type.toLowerCase() }} />
Die German translation for "No core documents for this {type}" is "Keine Hauptdokumente für diesen Lizenzvertrag verfügbar". Note that German requires Lizenzvertrag to start with a capital L. Using toLowerCase() is wrong for German.
In addition placeholders should be avoided. For details see
https://github.com/folio-org/stripes/blob/4bd81b6f9595040a12b8b71f47fb293fe587e214/doc/i18n.md#avoid-placeholders
Please expand the placeholder.
For example replace
"emptyAccordion.coreDocuments": "No core documents for this {type}",
by
"emptyAccordion.coreDocuments.license": "No core documents for this license",
Use similar expansions for all other possible values of {type}.
-> This is used for coreDocuments, Supplementary documents and Terms, and the types in use are Licenses and Amendments
TestRail: Results
Attachments
Issue Links
- relates to
-
-
- Closed
-