Uploaded image for project: 'edge-rtac'
  1. edge-rtac
  2. EDGRTAC-64

Replace equality comparisons with explicit assertions

    XMLWordPrintable

Details

    • Tech Debt
    • Status: Closed (View Workflow)
    • P3
    • Resolution: Done
    • None
    • 2.6.0
    • None
    • Prokopovych - Sprint 142
    • 5
    • Prokopovych
    • TBD

    Description

      Context

      Many of the tests in MainVerticleTests use a comparison between an expected holdings object and an interpreted response from the API.

      This makes it hard to understand what the expectations.

      It also seems to cause intermittent build issues.

      In that case, that build failure also caused an outage to our hosted reference environments, raising the priority of this work.

      Scope

      • Replace each comparison assertion in those tests with explicit assertions

      Note that the API returns a successful empty response when a failure occurs. This is an intentional design decision.

      It would be good to include comments (or similar) in these cases, to make that unexpected behaviour obvious to future readers.

      TestRail: Results

        Attachments

          Issue Links

            Activity

              People

                felkerk Kyle Felker
                marcjohnson Marc Johnson
                Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved:

                  TestRail: Runs

                    TestRail: Cases