Uploaded image for project: 'edge-patron'
  1. edge-patron
  2. EDGPATRON-92

Replace CompletableFuture with Future fixing spurious test failures

    XMLWordPrintable

Details

    • Bug
    • Status: Closed (View Workflow)
    • TBD
    • Resolution: Done
    • 4.9.0
    • 4.9.1, 4.10.0
    • None
    • CP: sprint 142
    • Core: Platform
    • Morning Glory (R2 2022)
    • TBD

    Description

      Timeout tests like MainVerticleTest.testPlaceInstanceHoldRequestTimeout have spurious test failures because CompletableFuture and Future may block each other:

      12:46:48 INFO  MockOkapi            Waiting for 6000 ms before continuing
      12:46:51 ERROR PatronHandler        Exception calling OKAPI
      io.vertx.core.VertxException: Connection was closed
      12:46:51 ERROR ?                    io.vertx.core.VertxException: Connection was closed
      12:46:51 DEBUG Wire                  << "HTTP/1.1 500 Internal Server Error[\r][\n]"
      12:46:51 DEBUG Wire                  << "content-type: application/json[\r][\n]"
      12:46:51 DEBUG Wire                  << "content-length: 62[\r][\n]"
      12:46:51 DEBUG Wire                  << "[\r][\n]"
      12:46:51 DEBUG aultClientConnection Receiving response: HTTP/1.1 500 Internal Server Error
      
      [ERROR]   MainVerticleTest.testPlaceItemHoldRequestTimeout:999 1 expectation failed.
      Expected status code <408> but was <500>.
      

      Solution: Replace CompletableFuture with Future

      TestRail: Results

        Attachments

          Issue Links

            Activity

              People

                julianladisch Julian Ladisch
                julianladisch Julian Ladisch
                Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved:

                  TestRail: Runs

                    TestRail: Cases